Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update social media card #725

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

visortelle
Copy link
Member

@visortelle visortelle commented Nov 6, 2023

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Prviews

Screenshot 2023-11-06 at 2 13 31 PM Screenshot 2023-11-06 at 2 13 50 PM Screenshot 2023-11-06 at 2 14 00 PM

Figma source

https://www.figma.com/file/lBTrwpOT3qtNXmuveKVtV4/Untitled?type=design&node-id=1%3A2&mode=design&t=ayAxjguyIoIzX2fS-1

Live test

https://socialsharepreview.com/?url=https://pulsar-site-git-social-media-image-teal-tools.vercel.app/

Note for the reviewer

Need to change the domain back to pulsar.apache.org in the Docusaurus config file (multiple places).

Copy link
Contributor

github-actions bot commented Nov 6, 2023

@visortelle Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@tisonkun
Copy link
Member

tisonkun commented Nov 6, 2023

Thank you! Just recover to the official URL and rebase then I can merge this PR.

Perhaps I will cleanup the unused assets later but it's another topic, lol.

@visortelle
Copy link
Member Author

@tisonkun done.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Waiting for the CI gives green.

@tisonkun tisonkun merged commit 13edf94 into apache:main Nov 6, 2023
2 checks passed
@tisonkun tisonkun deleted the social-media-image branch November 6, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants