[fix][c++ client] avoid race condition causing double callback on clo…

…se (#15508) * avoid race condition causing double callback on close * Update pulsar-client-cpp/lib/ClientImpl.cc Co-authored-by: Yunze Xu <xyzinfernity@163.com>
apache · May 9, 2022 · 2762bbc · 2762bbc
1 parent 6d16025
commit 2762bbc
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/pulsar-client-cpp/lib/ClientImpl.cc b/pulsar-client-cpp/lib/ClientImpl.cc
@@ -532,8 +532,13 @@ void ClientImpl::handleClose(Result result, SharedInt numberOfOpenHandlers, Resu
     }
     if (*numberOfOpenHandlers == 0) {
         Lock lock(mutex_);
-        state_ = Closed;
-        lock.unlock();
+        if (state_ == Closed) {
+            LOG_DEBUG("Client is already shutting down, possible race condition in handleClose");
+            return;
+        } else {
+            state_ = Closed;
+            lock.unlock();
+        }
 
         LOG_DEBUG("Shutting down producers and consumers for client");
         // handleClose() is called in ExecutorService's event loop, while shutdown() tried to wait the event