Fix read entires

apache · Aug 4, 2022 · 2cc107d · 2cc107d
1 parent 8a5e1c0
commit 2cc107d
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/...d-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/SharedEntryCacheImpl.java b/...d-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/SharedEntryCacheImpl.java
@@ -101,14 +101,19 @@ public void asyncReadEntry(ReadHandle lh, long firstEntry, long lastEntry, boole
         long totalCachedSize = entryCacheManager.getRange(ledgerId, firstEntry, lastEntry, cachedEntries);
 
         if (cachedEntries.size() == entriesToRead) {
+            final List<Entry> entriesToReturn = Lists.newArrayListWithExpectedSize(entriesToRead);
             // All entries found in cache
-            entryCacheManager.getFactoryMBean().recordCacheHits(entriesToRead, totalCachedSize);
+            for (Entry entry : cachedEntries) {
+                entriesToReturn.add(EntryImpl.create((EntryImpl) entry));
+                entry.release();
+            }
+            // All entries found in cache
+            entryCacheManager.getFactoryMBean().recordCacheHits(entriesToReturn.size(), totalCachedSize);
             if (log.isDebugEnabled()) {
                 log.debug("[{}] Ledger {} -- Found in cache entries: {}-{}", ml.getName(), ledgerId, firstEntry,
                         lastEntry);
             }
-
-            callback.readEntriesComplete(cachedEntries, ctx);
+            callback.readEntriesComplete(entriesToReturn, ctx);
 
         } else {
             if (!cachedEntries.isEmpty()) {