Skip to content

Commit

Permalink
[cleanup][cli] Cleanup jcommander
Browse files Browse the repository at this point in the history
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
  • Loading branch information
nodece committed Mar 25, 2024
1 parent 567174f commit 65bbcb6
Show file tree
Hide file tree
Showing 19 changed files with 17 additions and 421 deletions.
1 change: 0 additions & 1 deletion distribution/server/src/assemble/LICENSE.bin.txt
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,6 @@ support library is itself covered by the above license.
This projects includes binary packages with the following licenses:

The Apache Software License, Version 2.0
* JCommander -- com.beust-jcommander-1.82.jar
* Picocli
- info.picocli-picocli-4.7.5.jar
- info.picocli-picocli-shell-jline3-4.7.5.jar
Expand Down
1 change: 0 additions & 1 deletion distribution/shell/src/assemble/LICENSE.bin.txt
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,6 @@ pulsar-client-cpp/lib/checksum/crc32c_sw.cc
This projects includes binary packages with the following licenses:

The Apache Software License, Version 2.0
* JCommander -- jcommander-1.82.jar
* Picocli
- picocli-4.7.5.jar
- picocli-shell-jline3-4.7.5.jar
Expand Down
7 changes: 0 additions & 7 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,6 @@ flexible messaging model and an intuitive client API.</description>
<confluent.version>6.2.8</confluent.version>
<aircompressor.version>0.20</aircompressor.version>
<asynchttpclient.version>2.12.1</asynchttpclient.version>
<jcommander.version>1.82</jcommander.version>
<commons-lang3.version>3.11</commons-lang3.version>
<commons-configuration.version>1.10</commons-configuration.version>
<commons-io.version>2.8.0</commons-io.version>
Expand Down Expand Up @@ -693,12 +692,6 @@ flexible messaging model and an intuitive client API.</description>
<classifier>linux-aarch_64</classifier>
</dependency>

<dependency>
<groupId>com.beust</groupId>
<artifactId>jcommander</artifactId>
<version>${jcommander.version}</version>
</dependency>

<dependency>
<groupId>info.picocli</groupId>
<artifactId>picocli</artifactId>
Expand Down
5 changes: 0 additions & 5 deletions pulsar-cli-utils/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,6 @@
<description>Isolated CLI utility module</description>

<dependencies>
<dependency>
<groupId>com.beust</groupId>
<artifactId>jcommander</artifactId>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>info.picocli</groupId>
<artifactId>picocli</artifactId>
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import static org.testng.Assert.assertThrows;
import java.util.concurrent.TimeUnit;
import org.apache.pulsar.cli.converters.picocli.TimeUnitToMillisConverter;
import org.apache.pulsar.cli.converters.picocli.TimeUnitToSecondsConverter;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;

Expand Down Expand Up @@ -57,8 +58,8 @@ public void testSuccessfulRelativeTimeUtilParsing(String input, long expected) {
}

@Test(dataProvider = "successfulRelativeTimeUtilTestCases")
public void testSuccessfulTimeUnitToSecondsConverter(String input, long expected) {
TimeUnitToSecondsConverter secondsConverter = new TimeUnitToSecondsConverter("optionName");
public void testSuccessfulTimeUnitToSecondsConverter(String input, long expected) throws Exception {
TimeUnitToSecondsConverter secondsConverter = new TimeUnitToSecondsConverter();
assertEquals(secondsConverter.convert(input), Long.valueOf(expected));
}

Expand Down

This file was deleted.

Loading

0 comments on commit 65bbcb6

Please sign in to comment.