-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Enabled grpc plugin to gRPC generate.sh script to fix issues causing …
…omission of methods for gRPC server registration in generated gRPC files for Go. (#4175) Generated updated gRPC files that contain service registration methods for creating gRPC service in Go. Also, upgraded proto version to 3. (#4175) Fixed build errors by prefixing pulsar-function-go/pb with pb alias. (#4175). Added instanceControlServicer.go as the servicer responsible for serving the gRPC service for the Go Function instances (#4175). Rough draft right now. Added changes to show intent behind passing port value to Start in function.go. Also, added some code to support healthcheck and added methods to support instanceConrolServicer. Just needed to commit changes to allow reproducible test errors. (#4175). Updated function.go Start method to make it more clear where we need to provide a port value (#4175). Added port and expectedHealthCheckInterval to use of function context. Updated all references. (#4175) Added Apache license to gRPC-generated files in attempt to get license check test to pass (#4175). Created instanceControlServicer_test.go to test gRPC server and validate that HealthCheck method returns true as expected (#4175). Fixed bug in FunctionContext (and context_test.go) where the inputTopics field was being referenced when it wasn't getting populated. Updated GetInputTopics method to get input topics from the source location (#4175). Fixed bug in FunctionContext (and context_test.go) where the inputTopics field was being referenced when it wasn't getting populated. Updated GetInputTopics method to get input topics from the source location. (Should have been part of previous commit.) Also, added expectedHealthCheckInterval to conf.yaml for testing. (#4175). Fixed license formatting by running mvn license:format (#4175). Added logic and tests to allow healthCheck to kill instances that aren't receiving their regular health checks. Still needs an end-to-end test involving FunctionManager to check for possible issues that could kill instances incorrectly (#4175). Removed inputTopics field from FunctionContext (#4175). Adding the progress I've made so far on migrating the Prometheus code to Go... currently blocked due to missing methods from the Go client. Waiting for information from the Prometheus maintainers to find a workaround. (#4175). Fixed license check. (#4175) Reverting the last two commits since they should go into a separate PR. (#4174). Re-added test file that was accidentially deleted (#4175). Added a few comments to make review easier (#4175). Made minor (non-functional) changes as per PR review (#4175). Fixed print statements (#4175). Re-added comment after getting maven license formatting correct (#4175).
- Loading branch information
Devin Bost
committed
Jan 20, 2020
1 parent
055f3bb
commit 6e2174d
Showing
18 changed files
with
1,048 additions
and
241 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,3 +13,5 @@ require ( | |
| gopkg.in/natefinch/lumberjack.v2 v2.0.0 | ||
| gopkg.in/yaml.v2 v2.2.2 // indirect | ||
| ) | ||
|
|
||
| go 1.13 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,3 +55,4 @@ disk: 0 | |
| # retryDetails config | ||
| maxMessageRetries: 0 | ||
| deadLetterTopic: "" | ||
| expectedHealthCheckInterval: 3 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.