Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] The orderingKey doesn't get copied to DLQ or Retry letter messages #23173

Closed
2 of 3 tasks
lhotari opened this issue Aug 15, 2024 · 2 comments · Fixed by #23182
Closed
2 of 3 tasks

[Bug] The orderingKey doesn't get copied to DLQ or Retry letter messages #23173

lhotari opened this issue Aug 15, 2024 · 2 comments · Fixed by #23182
Assignees
@lhotari
Labels
area/client type/bug The PR fixed a bug or issue reported a bug

Comments

@lhotari
Copy link
Member

lhotari commented Aug 15, 2024

Search before asking

  • I searched in the issues and found nothing similar.

Read release policy

  • I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.

Version

any released version

Minimal reproduce step

There's no code to copy the orderingKey information from the source message to the target message that gets sent to the DLQ topic or Retry letter topic

What did you expect to see?

orderingKey should be preserved

What did you see instead?

orderingKey is currently ignored

Anything else?

Related to #23172

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@lhotari lhotari added type/bug The PR fixed a bug or issue reported a bug area/client labels Aug 15, 2024
@lhotari lhotari mentioned this issue Aug 15, 2024
Merged
15 tasks
@dlg99
Copy link
Contributor

dlg99 commented Aug 15, 2024

so far we only copy message value, key, and properties.
In addition to the orderingKey, do we need to copy values for anything else?

@lhotari
Copy link
Member Author

lhotari commented Aug 15, 2024

so far we only copy message value, key, and properties. In addition to the orderingKey, do we need to copy values for anything else?

@dlg99 I'm not aware of anything else missing.

@lhotari lhotari self-assigned this Aug 15, 2024
@lhotari lhotari mentioned this issue Aug 15, 2024
Merged
4 tasks
lhotari added a commit that referenced this issue Aug 16, 2024
@lhotari
[fix][client] Copy orderingKey to retry letter topic and DLQ messages…
c83428f 
… and fix bug in copying (#23182)

Fixes #23173
Fixes #23181

See #23173 and #23181

- copy ordering key to messages sent to retry letter topic and DLQ topic

(cherry picked from commit 67fc5b9)
lhotari added a commit that referenced this issue Aug 16, 2024
@lhotari
[fix][client] Copy orderingKey to retry letter topic and DLQ messages…
b1ecec4 
… and fix bug in copying (#23182)

Fixes #23173
Fixes #23181

### Motivation

See #23173 and #23181

### Modifications

- copy ordering key to messages sent to retry letter topic and DLQ topic

(cherry picked from commit 67fc5b9)
lhotari added a commit that referenced this issue Aug 16, 2024
@lhotari
[fix][client] Copy orderingKey to retry letter topic and DLQ messages…
ea9b7c2 
… and fix bug in copying (#23182)

Fixes #23173
Fixes #23181

See #23173 and #23181

- copy ordering key to messages sent to retry letter topic and DLQ topic

(cherry picked from commit 67fc5b9)
lhotari added a commit that referenced this issue Aug 16, 2024
@lhotari
[fix][client] Copy orderingKey to retry letter topic and DLQ messages…
a3f6577 
… and fix bug in copying (#23182)

Fixes #23173
Fixes #23181

### Motivation

See #23173 and #23181

### Modifications

- copy ordering key to messages sent to retry letter topic and DLQ topic

(cherry picked from commit 67fc5b9)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this issue Aug 16, 2024
@lhotari @nikhil-ctds
[fix][client] Copy orderingKey to retry letter topic and DLQ messages…
73d7b6d 
… and fix bug in copying (apache#23182)

Fixes apache#23173
Fixes apache#23181

See apache#23173 and apache#23181

- copy ordering key to messages sent to retry letter topic and DLQ topic

(cherry picked from commit 67fc5b9)
(cherry picked from commit c83428f)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this issue Aug 16, 2024
@lhotari @nikhil-ctds
[fix][client] Copy orderingKey to retry letter topic and DLQ messages…
b9e08b6 
… and fix bug in copying (apache#23182)

Fixes apache#23173
Fixes apache#23181

See apache#23173 and apache#23181

- copy ordering key to messages sent to retry letter topic and DLQ topic

(cherry picked from commit 67fc5b9)
(cherry picked from commit c83428f)
srinath-ctds pushed a commit to datastax/pulsar that referenced this issue Aug 20, 2024
@lhotari @srinath-ctds
[fix][client] Copy orderingKey to retry letter topic and DLQ messages…
42e9157 
… and fix bug in copying (apache#23182)

Fixes apache#23173
Fixes apache#23181

See apache#23173 and apache#23181

- copy ordering key to messages sent to retry letter topic and DLQ topic

(cherry picked from commit 67fc5b9)
(cherry picked from commit c83428f)
grssam pushed a commit to grssam/pulsar that referenced this issue Sep 4, 2024
@lhotari @grssam
[fix][client] Copy orderingKey to retry letter topic and DLQ messages…
98aba50 
… and fix bug in copying (apache#23182)

Fixes apache#23173
Fixes apache#23181


### Motivation

See apache#23173 and apache#23181

### Modifications

- copy ordering key to messages sent to retry letter topic and DLQ topic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhotari lhotari

Labels
area/client type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
No milestone
2 participants
@lhotari @dlg99