Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky-test: ManagedCursorTest.testForceCursorRecovery #23417

Closed
1 of 2 tasks
lhotari opened this issue Oct 8, 2024 · 6 comments · Fixed by #23518
Closed
1 of 2 tasks

Flaky-test: ManagedCursorTest.testForceCursorRecovery #23417

lhotari opened this issue Oct 8, 2024 · 6 comments · Fixed by #23518

Comments

@lhotari
Copy link
Member

lhotari commented Oct 8, 2024

Search before asking

  • I searched in the issues and found nothing similar.

Example failure

https://github.com/apache/pulsar/actions/runs/11232853373/job/31225793977?pr=23414#step:11:2927

Exception stacktrace

  Error:  Tests run: 282, Failures: 1, Errors: 0, Skipped: 202, Time elapsed: 36.683 s <<< FAILURE! - in org.apache.bookkeeper.mledger.impl.ManagedCursorTest
  Error:  org.apache.bookkeeper.mledger.impl.ManagedCursorTest.testForceCursorRecovery  Time elapsed: 0.031 s  <<< FAILURE!
  java.lang.AssertionError: expected [true] but found [false]
  	at org.testng.Assert.fail(Assert.java:110)
  	at org.testng.Assert.failNotEquals(Assert.java:1577)
  	at org.testng.Assert.assertTrue(Assert.java:56)
  	at org.testng.Assert.assertTrue(Assert.java:66)
  	at org.apache.bookkeeper.mledger.impl.ManagedCursorTest.testForceCursorRecovery(ManagedCursorTest.java:4831)
  	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
  	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
  	at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:139)
  	at org.testng.internal.invokers.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:47)
  	at org.testng.internal.invokers.InvokeMethodRunnable.call(InvokeMethodRunnable.java:76)
  	at org.testng.internal.invokers.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
  	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
  	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
  	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
  	at java.base/java.lang.Thread.run(Thread.java:1583)

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@lhotari
Copy link
Member Author

lhotari commented Oct 10, 2024

@lhotari
Copy link
Member Author

lhotari commented Oct 10, 2024

@rdhabalia Do you have a chance to fix this flaky test related to PIP-327? It fails very often. Thanks

@lhotari
Copy link
Member Author

lhotari commented Oct 23, 2024

@ZhaoGuorui666
Copy link
Contributor

@ZhaoGuorui666 here's a good candidate for fixing. Latest failures: https://github.com/lhotari/pulsar-flakes/blob/master/2024-10-23-14d-master/org.apache.bookkeeper.mledger.impl.ManagedCursorTest.testForceCursorRecovery.md

Thank you very much. I will carefully review these failures.

@ZhaoGuorui666
Copy link
Contributor

@lhotari I found an error while logging: BadVersionsException, and I also identified the issue: updating the cursor position information in the MetadataStore. The specific code is as follows:
image

I will continue to delve deeper into this issue tomorrow.

ZhaoGuorui666 added a commit to ZhaoGuorui666/pulsar that referenced this issue Oct 27, 2024
ZhaoGuorui666 added a commit to ZhaoGuorui666/pulsar that referenced this issue Oct 27, 2024
@ZhaoGuorui666
Copy link
Contributor

@lhotari I’ve submitted a pull request for review. Could you please take a look when you have time?

ZhaoGuorui666 added a commit to ZhaoGuorui666/pulsar that referenced this issue Oct 30, 2024
ZhaoGuorui666 added a commit to ZhaoGuorui666/pulsar that referenced this issue Oct 30, 2024
ZhaoGuorui666 added a commit to ZhaoGuorui666/pulsar that referenced this issue Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants