Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS Hostname verification undefined for C++/python client #2793

Closed
ivankelly opened this issue Oct 15, 2018 · 7 comments · Fixed by #7182 or #7191
Closed

TLS Hostname verification undefined for C++/python client #2793

ivankelly opened this issue Oct 15, 2018 · 7 comments · Fixed by #7182 or #7191
Assignees
@Jennifer88huang-zz
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. type/bug The PR fixed a bug or issue reported a bug

Comments

@ivankelly
Copy link
Contributor

I've not tested with code, but it looks like TLS hostname verification is a mess for the C++ client (and python by extension).

For binary connections, no hostname verification takes place as far as I can see. For http connections (for lookups) it takes place every time.

I suspect this made it through testing since the tls certs used to test C++ use localhost as the common name. We should expose the ability to add the host verification in the configuration.
@ivankelly
Copy link
Contributor Author

I'm currently adding documentation to security-tls-transport.md for hostname verification, and am stating that it doesn't work for C++. Please update the docs when this is fixed.

@ivankelly ivankelly mentioned this issue Oct 15, 2018
Closed
@ivankelly ivankelly added type/bug The PR fixed a bug or issue reported a bug component/c++ labels Oct 17, 2018
@sijie
Copy link
Member

sijie commented Mar 27, 2019

hostname verification has been added by #1215

@sijie sijie closed this as completed Mar 27, 2019
@ivankelly ivankelly reopened this Mar 27, 2019
@ivankelly
Copy link
Contributor Author

@sijie that change only added the implementation. documentation needs to be updated too.

@sijie sijie mentioned this issue Dec 27, 2019
Closed
@sijie sijie added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jan 14, 2020
@sijie
Copy link
Member

sijie commented Jan 14, 2020

@jennifer88huang this requires documentation updates.

@Jennifer88huang-zz
Copy link
Contributor

Got it.

@Jennifer88huang-zz
Copy link
Contributor

Jennifer88huang-zz commented Jan 15, 2020 •
edited
Loading

hostname verification has been added in C++ in #2475
This issue has been recorded in 2.3.0 missing docs.

@Huanli-Meng
Copy link
Contributor

@ivankelly , the doc is updated, could you please help review it? here is the PR link: #7162, Thanks.

This was referenced Jun 5, 2020
Merged
Merged
sijie pushed a commit that referenced this issue Jun 8, 2020
@Huanli-Meng
[Issue 2793][Doc]--Update TLS hostname verification for CPP and Pytho…
5db4d5f 
…n clients (#7182)

Fixes #2793 



### Motivation
Based on description in issue #2793, code example of host verification for C++ and Python clients are not correct. Therefore, update the security-tls-transport.md doc.

Doc for master has been updated and merged. This PR is for updating docs for previous releases.



### Modifications

1: update the TLS hostname verification code example for C++ and Python clients.
2: fix link errors.
3: re-arrange doc heading levels.
4: update the docs for the following releases: 2.5.2---2.2.0
cdbartholomew pushed a commit to kafkaesque-io/pulsar that referenced this issue Jul 24, 2020
@Huanli-Meng @cdbartholomew
[Issue 2793][Doc]--Update TLS hostname verification for CPP and Pytho…
090c735 
…n clients (apache#7182)

Fixes apache#2793 



### Motivation
Based on description in issue apache#2793, code example of host verification for C++ and Python clients are not correct. Therefore, update the security-tls-transport.md doc.

Doc for master has been updated and merged. This PR is for updating docs for previous releases.



### Modifications

1: update the TLS hostname verification code example for C++ and Python clients.
2: fix link errors.
3: re-arrange doc heading levels.
4: update the docs for the following releases: 2.5.2---2.2.0
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this issue Aug 24, 2020
@Huanli-Meng @huangdx0726
[Issue 2793][Doc]--Update TLS hostname verification for CPP and Pytho…
4afef92 
…n clients (apache#7182)

Fixes apache#2793 



### Motivation
Based on description in issue apache#2793, code example of host verification for C++ and Python clients are not correct. Therefore, update the security-tls-transport.md doc.

Doc for master has been updated and merged. This PR is for updating docs for previous releases.



### Modifications

1: update the TLS hostname verification code example for C++ and Python clients.
2: fix link errors.
3: re-arrange doc heading levels.
4: update the docs for the following releases: 2.5.2---2.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jennifer88huang-zz Jennifer88huang-zz

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
No milestone
4 participants
@ivankelly @sijie @Jennifer88huang-zz @Huanli-Meng