cleaned some code in GenericJsonRecord #10527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eolivelli @lhotari PTAL |
lhotari
added
the
type/cleanup
|
/pulsarbot run-failure-checks |
3 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
LGTM! |
hangc0276
approved these changes
May 11, 2021
eolivelli
requested changes
May 11, 2021
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/GenericJsonRecord.java
Show resolved
Hide resolved
the do-while loop was executed only once so removed the loop and optimised an inner for-loop to find binaryValue
|
/pulsarbot run-failure-checks |
eolivelli
approved these changes
May 12, 2021
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 12, 2021
(cherry picked from commit 24b0d06)
codelipenghui
pushed a commit
that referenced
this pull request
Jun 26, 2021
(cherry picked from commit 24b0d06)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The do-while loop was executed only once so removed the loop and optimized an inner for-loop to find binaryValue
Motivation
IDE warning
Modifications
Simplified the code