-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transaction] Transaction admin api get transaction coordinator status. #10639
Merged
codelipenghui
merged 4 commits into
apache:master
from
congbobo184:congbobo184_transaction_coordinator_status_admin_api
May 20, 2021
Merged
[Transaction] Transaction admin api get transaction coordinator status. #10639
codelipenghui
merged 4 commits into
apache:master
from
congbobo184:congbobo184_transaction_coordinator_status_admin_api
May 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_admin_api # Conflicts: # pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/PulsarAdminToolTest.java
eolivelli
approved these changes
May 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
}); | ||
} | ||
} else { | ||
asyncResponse.resume(new RestException(503, "Broker don't support transaction!")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about "This Broker is not configured with transactionCoordinatorEnabled=true." ?
codelipenghui
added
area/transaction
component/txn/coordinator
doc-required
Your PR changes impact docs and you will update later.
labels
May 20, 2021
codelipenghui
approved these changes
May 20, 2021
Confirmed w/ @congbobo184, the doc has been added in this PR. |
Anonymitaet
added
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
and removed
doc-required
Your PR changes impact docs and you will update later.
labels
May 20, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…s. (apache#10639) ## Motivation Transaction add admin api `getCoordinatorStatus` ## implement ``` /** The transaction coordinatorId. */ public long coordinatorId; /** The state of this transaction metadataStore. */ public String state; /** The sequenceId of transaction metadataStore. */ public long sequenceId; /** The low water mark of transaction metadataStore. */ public long lowWaterMark; ``` This is transaction buffer metrics. ### Verifying this change Add the tests for it
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…s. (apache#10639) ## Motivation Transaction add admin api `getCoordinatorStatus` ## implement ``` /** The transaction coordinatorId. */ public long coordinatorId; /** The state of this transaction metadataStore. */ public String state; /** The sequenceId of transaction metadataStore. */ public long sequenceId; /** The low water mark of transaction metadataStore. */ public long lowWaterMark; ``` This is transaction buffer metrics. ### Verifying this change Add the tests for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/transaction
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Transaction add admin api
getCoordinatorStatus
implement
This is transaction buffer metrics.
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (yes)
Anything that affects deployment: (no)