Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Creating a topic does not wait for creating cursor of replicators" #10674

Merged
merged 1 commit into from
May 22, 2021
Merged

Revert "Creating a topic does not wait for creating cursor of replicators" #10674

merged 1 commit into from
May 22, 2021

Conversation

merlimat
Copy link
Contributor

This reverts #6364 commit 336e971.

Motivation

There are few issues that were introduced in that commit:

  1. If a new replication cursor is create after the topic is loaded, that cursor might be missing some of the latest messages
  2. Many places in the code are assuming that the cursor is always present on the replicator and are failing with NPE when the cursor is not created (or fails to get created).

One such example is that metrics will stop getting reported because of an exception:

ERROR org.apache.pulsar.broker.stats.prometheus.PrometheusMetricsServlet - Failed to generate prometheus stats 
java.lang.NullPointerException: null                                                                                                                
         at org.apache.pulsar.broker.service.persistent.PersistentReplicator.getStats(PersistentReplicator.java:676) ~[org.apache.pulsar-pulsar-broker-2.7.
         at org.apache.pulsar.broker.service.persistent.PersistentTopic.lambda$getStats$45(PersistentTopic.java:1624) ~[org.apache.pulsar-pulsar-broker-2.7

@merlimat merlimat added this to the 2.8.0 milestone May 21, 2021
@merlimat merlimat merged commit e486492 into apache:master May 22, 2021
@merlimat merlimat deleted the fix-replicator-npe branch May 22, 2021 17:14
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
@merlimat @yangl
Revert "Creating a topic does not wait for creating cursor of replica…
e62a729 
…tors (apache#6364)" (apache#10674)

This reverts commit 336e971.
codelipenghui pushed a commit that referenced this pull request Jun 26, 2021
@merlimat @codelipenghui
Revert "Creating a topic does not wait for creating cursor of replica…
71b96a0 
…tors (#6364)" (#10674)

This reverts commit 336e971.

(cherry picked from commit e486492)
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Jun 26, 2021
@codelipenghui codelipenghui mentioned this pull request Jul 21, 2021
Merged
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@merlimat @ciaocloud
Revert "Creating a topic does not wait for creating cursor of replica…
205f359 
…tors (apache#6364)" (apache#10674)

This reverts commit 336e971.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@sijie sijie Awaiting requested review from sijie

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

@jiazhai jiazhai Awaiting requested review from jiazhai

Assignees

@merlimat merlimat

Labels
cherry-picked/branch-2.7 Archived: 2.7 is end of life release/2.7.3
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@merlimat @codelipenghui