Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Broker] Fixed the incorrectly used logger. #11047

Merged
merged 1 commit into from
Jun 25, 2021
Merged

[Broker] Fixed the incorrectly used logger. #11047

merged 1 commit into from
Jun 25, 2021

Conversation

mattisonchao
Copy link
Member

Motivation

I found some incorrectly used logger.

Modifications

  • Fixed the incorrectly used logger in the broker module.

- Fixed the incorrectly used logger in broker module.
@mattisonchao
Copy link
Member Author

@martint @lhotari If you have time, can you help me review the code? : )

@lhotari
Copy link
Member

lhotari commented Jun 23, 2021

@mattisonchao very useful.

If you'd like to check all logger usages, there's an error prone plugin https://github.com/KengoTODA/errorprone-slf4j which has been configured in Pulsar's pom.xml . It was added in #8879 . The PR describes how it can be run.

@mattisonchao
Copy link
Member Author

@lhotari I will do that, thanks to you ~

@mattisonchao
Copy link
Member Author

/pulsarbot rerun-failure-checks

@sijie sijie added this to the 2.9.0 milestone Jun 25, 2021
@sijie sijie merged commit 247a973 into apache:master Jun 25, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
### Motivation

I found some incorrectly used logger.

### Modifications

- Fixed the incorrectly used logger in the broker module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants