Close the replicator and replication client when delete cluster. #11342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when a cluster been deleted, the replicator and the replication client will not been closed. The producer of the replicator will try to reconnect to the deleted cluster continuously. We should close and cleanup the replicator and the replication client for the deleted cluster.
codelipenghui
requested review from
merlimat,
gaoran10,
sijie,
315157973,
congbobo184,
hangc0276 and
zymap
codelipenghui
added
release/2.7.3
release/2.8.1
type/bug
315157973
reviewed
Jul 18, 2021
| if (ot.isPresent()) { | ||
| Replicator r = ot.get().getReplicators().get(clusterName); | ||
| if (r != null && r.isConnected()) { | ||
| r.disconnect(true).whenComplete((v, e) -> f.complete(null)); |
There was a problem hiding this comment.
It looks like we should let failIfHasBacklog=false
There was a problem hiding this comment.
Nice catch, changed to false.
sijie
approved these changes
Jul 19, 2021
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Jul 20, 2021
…nt when delete cluster in branch-2.7.
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Jul 21, 2021
…nt when delete cluster in branch-2.7.
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Jul 22, 2021
…che#11342) ### Motivation Currently, when a cluster has been deleted, the replicator and the replication client will not be closed. The producer of the replicator will try to reconnect to the deleted cluster continuously. We should close and clean up the replicator and the replication client for the deleted cluster. ### Verifying this change A new test was added for verifying the replicator and the replication client will be closed after the cluster is deleted.
codelipenghui
pushed a commit
that referenced
this pull request
Jul 23, 2021
…n delete cluster in branch-2.7. (#11390)
codelipenghui
added a commit
that referenced
this pull request
Jul 23, 2021
) ### Motivation Currently, when a cluster has been deleted, the replicator and the replication client will not be closed. The producer of the replicator will try to reconnect to the deleted cluster continuously. We should close and clean up the replicator and the replication client for the deleted cluster. ### Verifying this change A new test was added for verifying the replicator and the replication client will be closed after the cluster is deleted. (cherry picked from commit 8a4147e)
lhotari
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 8, 2022
…che#11342) Currently, when a cluster has been deleted, the replicator and the replication client will not be closed. The producer of the replicator will try to reconnect to the deleted cluster continuously. We should close and clean up the replicator and the replication client for the deleted cluster. A new test was added for verifying the replicator and the replication client will be closed after the cluster is deleted. (cherry picked from commit 8a4147e)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2022
…che#11342) Currently, when a cluster has been deleted, the replicator and the replication client will not be closed. The producer of the replicator will try to reconnect to the deleted cluster continuously. We should close and clean up the replicator and the replication client for the deleted cluster. A new test was added for verifying the replicator and the replication client will be closed after the cluster is deleted. (cherry picked from commit 8a4147e) (cherry picked from commit 60d462a)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…che#11342) ### Motivation Currently, when a cluster has been deleted, the replicator and the replication client will not be closed. The producer of the replicator will try to reconnect to the deleted cluster continuously. We should close and clean up the replicator and the replication client for the deleted cluster. ### Verifying this change A new test was added for verifying the replicator and the replication client will be closed after the cluster is deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when a cluster has been deleted, the replicator and the replication client will not be closed.
The producer of the replicator will try to reconnect to the deleted cluster continuously.
We should close and clean up the replicator and the replication client for the deleted cluster.
Verifying this change
A new test was added for verifying the replicator and the replication client will be closed after the cluster is deleted.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
This is a bug fix, no need documentation.