Swap getTopicReference(topic) with serviceUnit.includes to reduce calling getTopicReference #11405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
315157973
approved these changes
Jul 21, 2021
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Jul 23, 2021
codelipenghui
added
release/2.8.1
type/enhancement
…opicName) to reduce calling getTopicReference
|
@Technoboy- Please try rebase the master branch |
sijie
approved these changes
Jul 23, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Jul 30, 2021
…opicName) to reduce calling getTopicReference (#11405) ### Motivation Swap getTopicReference(topic).isPresent() with serviceUnit.includes to avoid calling getTopicReference to many times. #### For contributor This is a small optimization and does not require documentation。 (cherry picked from commit 8b1d937)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…opicName) to reduce calling getTopicReference (apache#11405) ### Motivation Swap getTopicReference(topic).isPresent() with serviceUnit.includes to avoid calling getTopicReference to many times. #### For contributor This is a small optimization and does not require documentation。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Swap getTopicReference(topic).isPresent() with serviceUnit.includes to avoid calling getTopicReference to many times.
For contributor
This is a small optimization and does not require documentation。