Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Format and examples to specify a tenant/namespace for a topic. #11526

Closed
wants to merge 2 commits into from

Conversation

vsly-ru
Copy link

@vsly-ru vsly-ru commented Aug 1, 2021

Added topic's name format and examples to specify a tenant and namespace of the topic.
Previously not a single mention of "namespaces" and how to specify one.

Motivation & context

Make docs easier.
I'm learning Apache Pulsar and had a confusion by the fact word "namespace" not mentioned even once in the nodejs part of the documentation. So it was impossible to know how to specify a namespace and/or tenant during topic manipulation (subscribing or connecting with a producer).

Modifications

To address this problem, I added the topic name format (based on Pulsar console output) and examples to the documentation.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

This is modification to the documentation itself (and only).

Added topic's name format and examples to specify a tenant and namespace of the topic. 
Previously not a single mention of "namespaces" and how to specify one.
@Jennifer88huang-zz Jennifer88huang-zz added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Aug 2, 2021
Copy link
Member

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsly-ru many Thanks for your contribution. Does this affect only master or other versioned docs?
If latter, could you please help update all affected versions? Thanks

site2/docs/client-libraries-node.md Outdated Show resolved Hide resolved
@Anonymitaet
Copy link
Member

@tuteng could you please help review this PR from the technical perspective? Thanks

@Anonymitaet
Copy link
Member

@vsly-ru any progress of this PR? Thanks

@vsly-ru
Copy link
Author

vsly-ru commented Aug 7, 2021

@vsly-ru any progress of this PR? Thanks

Sorry, I'm not familiar how to apply this PR to a multiple branches, can you give me a hint? Thanks.

Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
@Jennifer88huang-zz Jennifer88huang-zz added this to the 2.9.0 milestone Aug 9, 2021
@Jennifer88huang-zz
Copy link
Contributor

@vsly-ru any progress of this PR? Thanks

Sorry, I'm not familiar how to apply this PR to a multiple branches, can you give me a hint? Thanks.

@vsly-ru If your update applies to other versions, you can update them accordingly in different versions here.
Here is an example: https://github.com/apache/pulsar/pull/10317/files

@@ -107,7 +107,7 @@ Here is an example:

```JavaScript
const producer = await client.createProducer({
topic: 'my-topic',
topic: 'my-topic', // or 'my-tenant/my-namespace/my-topic' to specify topic's property and namespace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
topic: 'my-topic', // or 'my-tenant/my-namespace/my-topic' to specify topic's property and namespace
topic: 'my-topic', // or 'my-tenant/my-namespace/my-topic' to specify topic's tenant and namespace

@Anonymitaet
Copy link
Member

Hi @vsly-ru any progress for the code and doc? Thanks.

@Anonymitaet
Copy link
Member

Hi @vsly-ru can you take a look at our comments and make changes? Thanks

@vsly-ru
Copy link
Author

vsly-ru commented Oct 2, 2021

Hi @vsly-ru can you take a look at our comments and make changes? Thanks

Sorry, I have encountered a lot of unexpected problems with Pulsar, e.g. [pulsar-error] [192.168.1.3:52152 -> pulsar_ip:6650] Read failed: End of file after the app relaunch randomly (and this error isn't even mentioned anywhere), calling PulsarClient.close() crashes the app with no reason and I couldn't even close the connection properly.
So I'm busy with gradually replacing Pulsar in some critical areas of the app I'm working on.
Sorry, I don't feel like participating with such a huge problems and time lost caused by Pulsar.

@eolivelli eolivelli modified the milestones: 2.9.0, 2.10.0 Oct 6, 2021
@Anonymitaet
Copy link
Member

Hi @vsly-ru, @sijia-w is willing to handle this doc change. Except master, are there any other doc versions that need to be updated? Thanks?

@sijia-w
Copy link
Contributor

sijia-w commented Oct 12, 2021

@Anonymitaet Shall I create a new pr after @vsly-ru replies to this message? Thank you.

@Anonymitaet
Copy link
Member

Anonymitaet commented Oct 13, 2021

@sijia-w I've confirmed w/ eng, now could you please help open another PR and update all versioned docs (from 2.2.0 to master) based on our comments? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants