-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Add a new configuration managedLedgerInfoCompressionType
#11563
Merged
hangc0276
merged 1 commit into
apache:master
from
gaoran10:doc-compress-managed-ledger-info-conf
Aug 6, 2021
Merged
[Doc] Add a new configuration managedLedgerInfoCompressionType
#11563
hangc0276
merged 1 commit into
apache:master
from
gaoran10:doc-compress-managed-ledger-info-conf
Aug 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…configuration doc
gaoran10
requested review from
eolivelli,
codelipenghui,
315157973,
hangc0276,
merlimat,
sijie and
Anonymitaet
August 5, 2021 07:58
Anonymitaet
reviewed
Aug 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. I’ve left some comments, PTAL.
@@ -349,6 +349,7 @@ brokerServiceCompactionThresholdInBytes|If the estimated backlog size is greater | |||
|haProxyProtocolEnabled | Enable or disable the [HAProxy](http://www.haproxy.org/) protocol. |false| | |||
| maxTopicsPerNamespace | The maximum number of persistent topics that can be created in the namespace. When the number of topics reaches this threshold, the broker rejects the request of creating a new topic, including the auto-created topics by the producer or consumer, until the number of connected consumers decreases. The default value 0 disables the check. | 0 | | |||
|subscriptionTypesEnabled| Enable all subscription types, which are exclusive, shared, failover, and key_shared. | Exclusive, Shared, Failover, Key_Shared | | |||
/ managedLedgerInfoCompressionType / ManagedLedgerInfo compression type, option values (NONE, LZ4, ZLIB, ZSTD, SNAPPY), if value is NONE or invalid, the managedLedgerInfo will not be compressed. Notice, after enable this configuration, if you want to degrade broker, you should change the configuration to `NONE` and make sure all ledger metadata are saved without compression. | None | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
/ managedLedgerInfoCompressionType / ManagedLedgerInfo compression type, option values (NONE, LZ4, ZLIB, ZSTD, SNAPPY), if value is NONE or invalid, the managedLedgerInfo will not be compressed. Notice, after enable this configuration, if you want to degrade broker, you should change the configuration to `NONE` and make sure all ledger metadata are saved without compression. | None | | |
| managedLedgerInfoCompressionType | Compression type of `ManagedLedgerInfo`. <br><br> Available values are `NONE`, `LZ4`, `ZLIB`, `ZSTD`, and `SNAPPY`. <br><br> If the value is `NONE` or invalid, the `managedLedgerInfo` is not compressed. <br><br> **Note** that after enabling this configuration, if you want to degrade broker, you need to change the value to `NONE` and ensure all ledger metadata are saved without compression before starting to degrade. | NONE | |
Fix #11490 |
codelipenghui
approved these changes
Aug 5, 2021
codelipenghui
added
the
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
label
Aug 5, 2021
315157973
approved these changes
Aug 5, 2021
hangc0276
approved these changes
Aug 6, 2021
LeBW
pushed a commit
to LeBW/pulsar
that referenced
this pull request
Aug 9, 2021
…configuration doc (apache#11563) ### Modifications Add a new configuration managedLedgerInfoCompressionType in broker configuration doc. Related to apache#11490
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…configuration doc (apache#11563) ### Modifications Add a new configuration managedLedgerInfoCompressionType in broker configuration doc. Related to apache#11490
momo-jun
added a commit
to momo-jun/pulsar
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
release/2.8.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
Add a new configuration
managedLedgerInfoCompressionType
in broker configuration doc.