Source tarball: apply executable file permissions to shell scripts (fixes #10917) #11858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
requested review from
hangc0276,
codelipenghui,
lhotari and
merlimat
|
according to @MMirelli comment on the VOTE thread for 2.8.1rc0 I have to set permissions on other files |
|
I have updated my patch, testing it locally now |
hangc0276
approved these changes
Aug 31, 2021
codelipenghui
approved these changes
Aug 31, 2021
hangc0276
pushed a commit
that referenced
this pull request
Aug 31, 2021
…ixes #10917) (#11858) The source tarball cannot be built because some .sh files are missing executable file permissions, see #10917 ### Modifications: copy the Source Assembly descriptor from the main Maven ASF repo to src add exclusions for "data" and "logs" set 755 permissions on every .sh file in "src" Tests: the build of the docker images and the C client uses the src tarball, so there is minimal test coverage. Apart from this the only way to test this patch is to try to build Pulsar from the generated source tarball * Source tarball: apply executable file permissions to shell scripts * Fix license header * add more .sh files * Fix docker build Co-authored-by: Enrico Olivelli <eolivelli@apache.org> (cherry picked from commit a5fc929)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…ixes apache#10917) (apache#11858) The source tarball cannot be built because some .sh files are missing executable file permissions, see apache#10917 ### Modifications: copy the Source Assembly descriptor from the main Maven ASF repo to src add exclusions for "data" and "logs" set 755 permissions on every .sh file in "src" Tests: the build of the docker images and the C client uses the src tarball, so there is minimal test coverage. Apart from this the only way to test this patch is to try to build Pulsar from the generated source tarball * Source tarball: apply executable file permissions to shell scripts * Fix license header * add more .sh files * Fix docker build Co-authored-by: Enrico Olivelli <eolivelli@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source tarball cannot be built because some .sh files are missing executable file permissions, see #10917
Modifications:
Tests:
the build of the docker images and the C client uses the src tarball, so there is minimal test coverage.
Apart from this the only way to test this patch is to try to build Pulsar from the generated source tarball