[Broker] Only store authentication data after authentication is complete

[michaeljmarshall]

Motivation

The ServerCnx class stores the most recent AuthenticationDataSource for a connection in the authenticationData field. This should not be stored until the authentication state isComplete has returned true. Since the ServerCnx state does not go to Connected until after the auth state has completed, this is really just a cosmetic change.

For historical context, it looks like this line was added a while ago here: #5462. At that time, the doAuthentication method did not set the authenticationState field. The method now sets that field, so I think we should remove this line.

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java

Lines 623 to 632 in fb76b23

	if (authState.isComplete()) {
	// Authentication has completed. It was either:
	// 1. the 1st time the authentication process was done, in which case we'll send
	// a `CommandConnected` response
	// 2. an authentication refresh, in which case we need to refresh authenticationData
	String newAuthRole = authState.getAuthRole();
	// Refresh the auth data.
	this.authenticationData = authState.getAuthDataSource();

Modifications

• Remove the premature setting of authentication data in ServerCnx

Verifying this change

This change is mostly cosmetic. The authenticationData field is only used when the class's state is Connected, and that only happens after the authentication state has returned true for isComplete. As such, I think tests passing will be enough to ensure correctness.

Does this pull request potentially affect one of the following parts:

This change is not breaking.

Documentation

No docs required.

[lhotari]

Closing and re-opening to trigger a new fresh test run.

[michaeljmarshall]

/pulsarbot run-failure-checks

[michaeljmarshall]

Just rebased. The same line is the only change.