Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Standalone] Print log when configuration is failed to load #12280

Merged
merged 3 commits into from
Oct 12, 2021
Merged

[Standalone] Print log when configuration is failed to load #12280

merged 3 commits into from
Oct 12, 2021

Conversation

tomscut
Copy link
Contributor

@tomscut tomscut commented Oct 5, 2021 •
edited
Loading

Motivation

Print log when configuration is failed to load.

Modifications

Print log when config is null.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-required
  • no-need-doc
  • doc

@tomscut tomscut changed the title [Standalone] Remove redundant judgment for PulsarStandalone#start [Standalone] Print log when configuration is failed to load Oct 9, 2021
@tomscut
Copy link
Contributor Author

tomscut commented Oct 11, 2021

Failed unit tests are unrelated to this change. @hangc0276 PTAL, Thanks.

@hangc0276 hangc0276 added this to the 2.10.0 milestone Oct 11, 2021
@tomscut tomscut removed their assignment Oct 11, 2021
@hangc0276 hangc0276 merged commit 6c03e53 into apache:master Oct 12, 2021
@tomscut
Copy link
Contributor Author

tomscut commented Oct 12, 2021

Thanks @hangc0276 @315157973 @k2la for your review.

hangc0276 pushed a commit that referenced this pull request Oct 17, 2021
@tomscut @hangc0276
[Standalone] Print log when configuration is failed to load (#12280)
e707546 
### Motivation
Print log when configuration is failed to load.

### Modifications
Print log when config is null.

(cherry picked from commit 6c03e53)
@hangc0276 hangc0276 added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Oct 17, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@tomscut @ciaocloud
[Standalone] Print log when configuration is failed to load (apache#1…
bf7e0e4 
…2280)

### Motivation
Print log when configuration is failed to load.

### Modifications
Print log when config is null.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k2la k2la k2la approved these changes

@315157973 315157973 315157973 approved these changes

@hangc0276 hangc0276 hangc0276 approved these changes

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

Assignees

@tomscut tomscut

Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life release/2.8.2
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tomscut @hangc0276 @315157973 @k2la