Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant code #12424

Merged
merged 1 commit into from
Oct 21, 2021
Merged

remove redundant code #12424

merged 1 commit into from
Oct 21, 2021

Conversation

aloyszhang
Copy link
Contributor

@aloyszhang aloyszhang commented Oct 19, 2021 •
edited
Loading

Motivation

Remove reduncant code

Modifications

Remove one line reduncant code

Verifying this change

This change is a code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API: ( no)
  • The schema: ( no)
  • The default values of configurations: ( no)
  • The wire protocol: ( no)
  • The rest endpoints: ( no)
  • The admin cli options: ( no)
  • Anything that affects deployment: ( no)

Documentation

Need to update docs?

  • no-need-doc

@eolivelli
Copy link
Contributor

@aloyszhang:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@eolivelli
Copy link
Contributor

@aloyszhang:Thanks for providing doc info!

@eolivelli eolivelli added the doc-not-needed Your PR changes do not impact docs label Oct 19, 2021
@aloyszhang
Copy link
Contributor Author

@eolivelli PTAL this pull request.

@aloyszhang
Copy link
Contributor Author

cc @BewareMyPower

@BewareMyPower BewareMyPower added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Oct 21, 2021
@BewareMyPower BewareMyPower merged commit 4d4db6b into apache:master Oct 21, 2021
codelipenghui pushed a commit that referenced this pull request Oct 21, 2021
@aloyszhang @codelipenghui
remove redundant code (#12424)
eb29c69 
### Motivation

Remove  reduncant code

### Modifications

Remove one line reduncant code

(cherry picked from commit 4d4db6b)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Oct 21, 2021
@codelipenghui codelipenghui added this to the 2.10.0 milestone Oct 21, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
@aloyszhang @eolivelli
remove redundant code (apache#12424)
7170f51 
### Motivation

Remove  reduncant code

### Modifications

Remove one line reduncant code
@aloyszhang aloyszhang deleted the rm-dup branch November 30, 2021 12:29
codelipenghui pushed a commit that referenced this pull request Dec 20, 2021
@aloyszhang @codelipenghui
remove redundant code (#12424)
72804d4 
### Motivation

Remove  reduncant code

### Modifications

Remove one line reduncant code

(cherry picked from commit 4d4db6b)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 20, 2021
@gaoran10 gaoran10 added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use and removed type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BewareMyPower BewareMyPower BewareMyPower approved these changes

@yuruguo yuruguo yuruguo approved these changes

Assignees

@aloyszhang aloyszhang

Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2 release/2.9.2 type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@aloyszhang @eolivelli @yuruguo @BewareMyPower @codelipenghui @gaoran10