Fix collection get bug in ResourceGroupService #12499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shoothzj:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
doc-label-missing
doc-not-needed
pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupService.java
Show resolved
Hide resolved
codelipenghui
approved these changes
Oct 26, 2021
merlimat
approved these changes
Oct 26, 2021
|
/pulsarbot run-failure-checks |
|
The test failures are related to this change. |
You are right, the former code can't calculate the namespace resource group, then some test code are based on wrong code. I'll fix that |
1 task
hezhangjian
force-pushed
the
resourcegroup-service-1026
branch
from
1ffdc37 to
8242c9f
Compare
|
/pulsarbot run-failure-checks |
|
@merlimat PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The wrong get will always return null.
Modifications
Change
java.lang.Stringtype toNamespaceNametypeDocumentation
Need to update docs?
no-need-docLittle bug fix