Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulsar-admin] Add --all option to get all version schema of topic #12535

Merged
merged 2 commits into from
Nov 15, 2021
Merged

[pulsar-admin] Add --all option to get all version schema of topic #12535

merged 2 commits into from
Nov 15, 2021

Conversation

yuruguo
Copy link
Contributor

@yuruguo yuruguo commented Oct 29, 2021

Motivation

Add --all option to get all version schema of topic when we use CLI ./bin/pulsar-admin schemas get tenant/ns/tp

Documentation

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 29, 2021
@github-actions
Copy link

@yuruguo:Thanks for providing doc info!

Copy link
Contributor

@315157973 315157973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloud you please add some unit tests in PulsarAdminToolTest ?

@yuruguo
Copy link
Contributor Author

yuruguo commented Nov 3, 2021

Cloud you please add some unit tests in PulsarAdminToolTest ?

Sure, the test of schemes has been added, PTAL again

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not commit .jar files to the repository

@eolivelli
Copy link
Contributor

@merlimat in this patch we would commit a .jar file on the source repo, this is usually prohibited from ASF rules,
it is strange that CI passed.

does any ring bell ? do you remember why we allow this ?
I will start a thread on dev@

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codelipenghui codelipenghui added this to the 2.10.0 milestone Nov 15, 2021
@codelipenghui codelipenghui added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages release/2.9.1 labels Nov 15, 2021
@codelipenghui codelipenghui merged commit 2609c78 into apache:master Nov 15, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
…pache#12535)

### Motivation
Add `--all` option to get all version schema of topic when we use CLI `./bin/pulsar-admin schemas get tenant/ns/tp`
fxbing pushed a commit to fxbing/pulsar that referenced this pull request Dec 19, 2021
…pache#12535)

### Motivation
Add `--all` option to get all version schema of topic when we use CLI `./bin/pulsar-admin schemas get tenant/ns/tp`
codelipenghui pushed a commit that referenced this pull request Dec 20, 2021
…12535)

### Motivation
Add `--all` option to get all version schema of topic when we use CLI `./bin/pulsar-admin schemas get tenant/ns/tp`

(cherry picked from commit 2609c78)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.9.2 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants