-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pulsar-admin] Add --all option to get all version schema of topic #12535
[pulsar-admin] Add --all option to get all version schema of topic #12535
Conversation
@yuruguo:Thanks for providing doc info! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cloud you please add some unit tests in PulsarAdminToolTest ?
Sure, the test of schemes has been added, PTAL again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not commit .jar files to the repository
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java
Outdated
Show resolved
Hide resolved
@merlimat in this patch we would commit a .jar file on the source repo, this is usually prohibited from ASF rules, does any ring bell ? do you remember why we allow this ? |
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…pache#12535) ### Motivation Add `--all` option to get all version schema of topic when we use CLI `./bin/pulsar-admin schemas get tenant/ns/tp`
…pache#12535) ### Motivation Add `--all` option to get all version schema of topic when we use CLI `./bin/pulsar-admin schemas get tenant/ns/tp`
Motivation
Add
--all
option to get all version schema of topic when we use CLI./bin/pulsar-admin schemas get tenant/ns/tp
Documentation
no-need-doc