Add support of auth&auth at discovery BinaryProto-lookup #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
added
the
type/enhancement
|
CLA is valid! |
1 similar comment
|
CLA is valid! |
merlimat
reviewed
Nov 28, 2016
| @@ -78,7 +78,7 @@ public void run() { | |||
| protected static void startWebService(ServerManager server, ServiceConfig config) throws Exception { | |||
| // add servlet | |||
| Map<String, String> initParameters = new TreeMap<>(); | |||
| initParameters.put("zookeeperServers", config.getZookeeperServers()); | |||
| initParameters.put("localZookeeperServers", config.getLocalZookeeperServers()); | |||
There was a problem hiding this comment.
We've being using zookeeperServers elsewhere for the "local ZK connection", we should not change it just here
There was a problem hiding this comment.
Also, we update the docs at https://github.com/yahoo/pulsar/blob/master/docs/ClusterSetup.md#service-discovery to add the newly introduced keys.
rdhabalia
force-pushed
the
auth_disc
branch
3 times, most recently
from
1f350e4
to
7e260a9
Compare
rdhabalia
commented
Nov 29, 2016
| @@ -560,14 +559,3 @@ CommandPartitionedTopicMetadataResponse { | |||
| "partitions" : 32 | |||
| } | |||
| ``` | |||
|
|
|||
| Example of response with redirection: | |||
There was a problem hiding this comment.
should we also include error response for TopicLookup and PartitionedMetadataLookup
|
removed |
|
@merlimat : have addressed all the changes. can you please let me know if we need any other changes. |
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
* Added runtime descriptor in functionConfig * Fixed unittest
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
* Add lib license for pulsar-client-go Signed-off-by: xiaolong.ran <rxl@apache.org> * add the path of license file Signed-off-by: xiaolong.ran <rxl@apache.org>
massakam
pushed a commit
to massakam/pulsar
that referenced
this pull request
Feb 9, 2021
* feature: implement GetProducerName * feature: implement GetTopic * feature: test explicit producer name
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
cbornet
pushed a commit
to cbornet/pulsar
that referenced
this pull request
Aug 31, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Discovery BinaryProto-Lookup service
Modifications
Result
Enabling authentication and authorization at discovery lookup service