[Transaction]stop TP replaying with Exception #12700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
approved these changes
Nov 19, 2021
codelipenghui
approved these changes
Nov 19, 2021
codelipenghui
changed the title
liangyepianzhou
changed the title
eolivelli
requested changes
Nov 20, 2021
...er/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java
Outdated
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
|
@eolivelli please review again, THX! |
|
@eolivelli Please help review this PR. |
eolivelli
reviewed
Dec 17, 2021
| return; | ||
| } | ||
| fillEntryQueueCallback.fillQueue(); | ||
| if (cursor.isClosed()) { |
There was a problem hiding this comment.
why did you move this outside of the while loop ?
There was a problem hiding this comment.
if cursor close will return ManagedledgerfenceException, so can delete this code, to speed up recovery
...er/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java
Outdated
Show resolved
Hide resolved
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
### Motivation When MLPendingAckStore replaying, if any ledger was deleted from bookkeeper, or ManagerLedger was fenced, MLPendingAckStore will not stop recovering and continue to report the exception. ### Modifications End replaying when there is no ledger to read or the managerLedger is fenced. ### Verifying this change Add a unit test.
codelipenghui
pushed a commit
that referenced
this pull request
Dec 21, 2021
When MLPendingAckStore replaying, if any ledger was deleted from bookkeeper, or ManagerLedger was fenced, MLPendingAckStore will not stop recovering and continue to report the exception. End replaying when there is no ledger to read or the managerLedger is fenced. Add a unit test. (cherry picked from commit a962137)
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Dec 29, 2021
### Motivation When MLPendingAckStore replaying, if any ledger was deleted from bookkeeper, or ManagerLedger was fenced, MLPendingAckStore will not stop recovering and continue to report the exception. ### Modifications End replaying when there is no ledger to read or the managerLedger is fenced. ### Verifying this change Add a unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When MLPendingAckStore replaying, if any ledger was deleted from bookkeeper, or ManagerLedger was fenced, MLPendingAckStore will not stop recovering and continue to report the exception.
Modifications
End replaying when there is no ledger to read or the managerLedger is fenced.
Verifying this change
Add a unit test.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docBug Fixes.