Even if always compatible is set, Consumers cannot be created #12721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Nov 10, 2021
| @@ -378,6 +378,9 @@ public String getReplicatorPrefix() { | |||
|
|
|||
| @Override | |||
| public CompletableFuture<Void> checkSchemaCompatibleForConsumer(SchemaData schema) { | |||
| if (SchemaCompatibilityStrategy.ALWAYS_COMPATIBLE.equals(schemaCompatibilityStrategy)) { | |||
There was a problem hiding this comment.
It's better to move into checkConsumerCompatibility() method?
eolivelli
requested changes
Nov 10, 2021
| @@ -270,6 +270,9 @@ private void checkCompatible(SchemaAndMetadata existingSchema, SchemaData newSch | |||
| @Override | |||
| public CompletableFuture<Void> checkConsumerCompatibility(String schemaId, SchemaData schemaData, | |||
| SchemaCompatibilityStrategy strategy) { | |||
| if (SchemaCompatibilityStrategy.ALWAYS_COMPATIBLE.equals(strategy)) { | |||
There was a problem hiding this comment.
this is an enum, please use "=="
|
over all LGTM I left one comment |
Done |
RobertIndie
approved these changes
Nov 10, 2021
|
@eolivelli PTAL |
codelipenghui
pushed a commit
that referenced
this pull request
Nov 18, 2021
(cherry picked from commit c3da145)
codelipenghui
added
cherry-picked/branch-2.8
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Dec 20, 2021
(cherry picked from commit c3da145)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the Producer's schema is set to AUTO_PRODUCE_BYTES. Even if always compatible is set, Consumers cannot be created. And return Exception
Topic does not have schema to checkDocumentation
no-need-doc