[Issue 12897] Fix flaky test in testReplicatorProducerName #12898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Nov 19, 2021
hezhangjian
approved these changes
Nov 20, 2021
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Nov 23, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Dec 21, 2021
(cherry picked from commit 78c2981)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12897
Motivation
See #12897
Modifications
Use
Awaitility.await().untilAssertedto wait until pulsar2 got the replicator producer.Verifying this change
This change is already covered by existing tests, such as testReplicatorProducerName
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docfix flaky test