Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Broker] Consider topics in pulsar/system namespace as system topics #13050

Merged
merged 1 commit into from
Dec 1, 2021
Merged

[Broker] Consider topics in pulsar/system namespace as system topics #13050

merged 1 commit into from
Dec 1, 2021

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Nov 30, 2021

Motivation

The current system topic concept doesn't seem to be consistent. It would be expected that topics in the "pulsar/system" namespace are considered as system topics.

Modifications

Change SystemTopicClient.isSystemTopic to consider all topics in pulsar/system namespace to be system topics.

@lhotari lhotari added the type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use label Nov 30, 2021
@lhotari lhotari added this to the 2.10.0 milestone Nov 30, 2021
@lhotari lhotari self-assigned this Nov 30, 2021
@github-actions
Copy link

@lhotari:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

1 similar comment
@github-actions
Copy link

@lhotari:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@eolivelli
Copy link
Contributor

@lhotari what it is a "System topic" ?

@lhotari
Copy link
Member Author

lhotari commented Nov 30, 2021

what it is a "System topic" ?

@eolivelli The concept was introduced by #4955 / PIP-39.

@lhotari lhotari added the doc-not-needed Your PR changes do not impact docs label Nov 30, 2021
@github-actions
Copy link

@lhotari:Thanks for providing doc info!

@eolivelli
Copy link
Contributor

Thank you @lhotari for your pointer.

I see that PIP-39 is still in "draft" status.
@sijie or @codelipenghui do you mind marking as Accepted and cleaning up the Wiki for PIP-39 ?

eolivelli
eolivelli approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari requested review from jiazhai and wolfstudy November 30, 2021 15:59
@lhotari
Copy link
Member Author

lhotari commented Nov 30, 2021

@codelipenghui Would you mind taking a look at this PR?

@codelipenghui codelipenghui merged commit d34379f into apache:master Dec 1, 2021
zeo1995 pushed a commit to zeo1995/pulsar that referenced this pull request Dec 1, 2021
Merge branch 'up/master' into website/branch-2.6.1-part-5
f6b0a66 
* up/master: (75 commits)
  [website][upgrade]feat: website upgrade / docs migration - 2.5.1 Get Started/Concepts and Architecture/Pulsar Schema (apache#13030)
  Fix environment variable assignment in startup scripts (apache#13025)
  update 2.8.x (apache#13029)
  [Doc] add tips for Pulsar tools (apache#13044)
  Suggest to use tlsPort instead of deprecated TlsEnable (apache#13039)
  Integration tests for function-worker rebalance and drain operations. (apache#13058)
  fix(functions): missing runtime set in GoInstanceConfig (apache#13031)
  [pulsar-admin] Add get-replicated-subscription-status command for topic (apache#12891)
  [Broker] Consider topics in pulsar/system namespace as system topics (apache#13050)
  Fix typo: correct sizeUint to sizeUnit (apache#13040)
  fix-12894 (apache#12896)
  Don't attempt to delete pending ack store unless transactions are enabled (apache#13041)
  [Perf] Evaluate the current protocol version once (apache#13045)
  Fix Issue apache#12885, Unordered consuming case in Key_Shared subscription (apache#12890)
  [broker]Optimize topicMaxMessageSize with topic local cache. (apache#12830)
  [PIP-105] Part-2 Support pluggable entry filter in Dispatcher (apache#12970)
  [website] Modify admin-api-topic.md document (apache#12996)
  add missed import (apache#13037)
  [metadata] Add RocksdbMetadataStore (apache#12776)
  [C] Add pulsar_client_subscribe_multi_topics and pulsar_client_subscribe_pattern (apache#12965)
  ...

# Conflicts:
#	site2/website-next/docusaurus.config.js
#	site2/website-next/versioned_sidebars/version-2.6.1-sidebars.json
#	site2/website-next/versions.json
fxbing pushed a commit to fxbing/pulsar that referenced this pull request Dec 19, 2021
@lhotari
[Broker] Consider topics in pulsar/system namespace as system topics (a…
a403f89 
…pache#13050)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@eolivelli eolivelli eolivelli approved these changes

@merlimat merlimat merlimat approved these changes

@congbobo184 congbobo184 Awaiting requested review from congbobo184

@jiazhai jiazhai Awaiting requested review from jiazhai

@wolfstudy wolfstudy Awaiting requested review from wolfstudy

Assignees

@lhotari lhotari

Labels
doc-not-needed Your PR changes do not impact docs type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lhotari @eolivelli @merlimat @codelipenghui