fix flaky test for BrokerServiceLookupTest.testModularLoadManagerSplitBundle #13159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wuzhanpeng:Thanks for your contribution. For this PR, do we need to update docs? |
|
@wuzhanpeng:Thanks for providing doc info! |
315157973
approved these changes
Dec 7, 2021
|
@Shoothzj Could you please take a look? |
hangc0276
approved these changes
Dec 7, 2021
lhotari
approved these changes
Dec 7, 2021
|
@wuzhanpeng Thanks for fixing one of the most flaky tests. Good work! |
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…dle (apache#13159) Co-authored-by: wuzhanpeng <wuzhanpeng@bigo.sg>
|
This didn't fix the problem. I reopened the issue #13102. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #13102
It is invalid to set the
loadBalancerNamespaceBundleMaxTopics=1after the initialization is completed, and the condition ofstats.topics = 2 > maxBundleTopics = 1000(default)can not be established, so the operation of bundle-split can not be triggered after the leader transfer.Documentation
no-need-docno doc is required to update.