[Broker] Optimize ManagedLedger Ledger Ownership Check #13222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
added
type/enhancement
michaeljmarshall
requested review from
hangc0276,
codelipenghui,
congbobo184,
eolivelli and
lhotari
and removed request for
hangc0276 and
codelipenghui
merlimat
approved these changes
Dec 10, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Dec 11, 2021
(cherry picked from commit 02b8de0)
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Dec 21, 2021
(cherry picked from commit 02b8de0)
zymap
pushed a commit
that referenced
this pull request
Dec 23, 2021
(cherry picked from commit 02b8de0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The logic added in #11912 forces all reads to check for containment in the managed ledger's collection of ledgers. Since the current ledger is always a member of the managed ledger's collection of ledgers, we can add an optimization that skips this check when reading from the current ledger. Note that all tail reads go through this part of the code, even if they're hitting the broker's cache.
Modifications
ManagedLedger#asyncReadEntry.Verifying this change
The test added in #11912 still passes, so this has the correct logic.
Does this pull request potentially affect one of the following parts:
This is not a breaking change.
Documentation
no-need-doc