Integrate function cli into pulsar-admin cli #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cated license headers This addresses some comments in pulsar functions PR apache#1314
…keeper version This removes the temp dependency in `pulsar-functions-instance`
|
/cc @srkukarni @jerrypeng |
- rename `pulsar-client-tools-shaded` to `pulsar-client-admin-shaded-for-functions`, because this module is used by functions only to avoid protobuf conflicts - move protobuf3 references to Utils, so it won't be referenced out side of pulsar-functions - integrate function cli into pulsar-admin cli
sijie
force-pushed
the
integrate_functions_cli
branch
from
701df16
to
c5a7779
Compare
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is based on #1329
701df16 is the commit for review in this PR.
pulsar-client-tools-shadedtopulsar-client-admin-shaded-for-functions, because this module is used by functions only to avoid protobuf conflicts701df16