Deprecate apachepulsar/pulsar-grafana docker image #13389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
added
type/cleanup
github-actions
bot
added
the
doc
|
Note that we currently use this docker image in a dcos example here pulsar/deployment/dcos/PulsarGroups.json Line 310 in c5d7a84 I think it might be worth removing the DCOS example all together, since it hasn't been updated in 4 years. |
Anonymitaet
reviewed
Dec 20, 2021
|
Can you start a mail thread in the pulsar maillist so that users and devs can get updates about this PR? |
@freeznet - yes, my plan is to send a note once I get tests passing. |
merlimat
approved these changes
Dec 20, 2021
codelipenghui
approved these changes
Dec 23, 2021
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Dec 29, 2021
* Deprecate apachepulsar/pulsar-grafana docker image * Add license to new file
1 task
michaeljmarshall
added a commit
that referenced
this pull request
Jan 6, 2022
Related PRs: #13387 #13389 ### Motivation Remove the DC/OS deployment example documentation and example json, since it was not maintained. I leave the DC/OS images in place, as those are still in use by old DC/OS docs. ### Verifying this change This change is a trivial removal of an example. ### Does this pull request potentially affect one of the following parts: This change removes a potentially helpful example, so I have discussed it on the mailing list here: https://lists.apache.org/thread/gzjoz9t7wbm4r59scx7497ry9cs4mdd0 ### Documentation - [x] `doc`
1 task
michaeljmarshall
added a commit
that referenced
this pull request
Jan 7, 2022
### Motivation In #13389, I removed the `apachepulsar/pulsar-grafana` docker image. I missed a reference in our publish scripts. Cleaning that up in this PR. ### Verifying this change Trivial change. ### Does this pull request potentially affect one of the following parts: No. ### Documentation - [x] `no-need-doc` This is an internal change to a script.
liudezhi2098
pushed a commit
to liudezhi2098/pulsar
that referenced
this pull request
Jan 11, 2022
### Motivation In apache#13389, I removed the `apachepulsar/pulsar-grafana` docker image. I missed a reference in our publish scripts. Cleaning that up in this PR. ### Verifying this change Trivial change. ### Does this pull request potentially affect one of the following parts: No. ### Documentation - [x] `no-need-doc` This is an internal change to a script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Clean up our
dockerdirectory. We currently produce a very outdatedpulsar-grafanadocker image with each release. The primary reason we're producing this image is to package grafana dashboards. Grafana allows easy import through the UI, or if you're running on Kubernetes, you can provide the dashboards as config maps. Given how old these files are, it looks like the dashboards do not receive much attention.Modifications
pulsar-grafanadocker image.Verifying this change
Once tests pass, I'll send a note to the dev mailing list to make sure we get the right visibility on this change before merging it.
Does this pull request potentially affect one of the following parts:
This PR deprecates our custom grafana docker image.
Documentation
docI updated the latest docs with this change.