[C++] Fix Wireshark dissector decode send command metadata behavior #13471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Dec 23, 2021
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Dec 23, 2021
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Dec 29, 2021
…pache#13471) ### Motivation Currently, the Wireshark dissector doesn't decode send message command metadata correctly, and some TCP packages are marked incorrectly when using pulsar dissector. ### Modifications - Fix decode send command metadata behavior - Fix dissect pulsar message marked incorrect TCP packages - Add DEBUG message for debugging - Support decode more Send command metadata info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the Wireshark dissector doesn't decode send message command metadata correctly, and some TCP packages are marked incorrectly when using pulsar dissector.
Modifications
Documentation
no-need-doc