Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clean code] clean unused method: getRangeConsumer #13775

Merged
merged 4 commits into from
Jan 26, 2022

Conversation

lordcheng10
Copy link
Contributor

@lordcheng10 lordcheng10 commented Jan 16, 2022

Motivation

clean unused method: getRangeConsumer in class HashRangeAutoSplitStickyKeyConsumerSelector and ConsistentHashingStickyKeyConsumerSelector

Documentation

Check the box below or label this PR directly (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 16, 2022
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@mattisonchao
Copy link
Member

@lordcheng10
This PR needs to wait for #13772 to be merged, then close and reopen it.

Copy link
Member

@mattisonchao mattisonchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@lordcheng10
Copy link
Contributor Author

ping

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

Copy link
Member

@hezhangjian hezhangjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove the import

@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 18, 2022
@codelipenghui
Copy link
Contributor

@lordcheng10 Please rebase to the master branch

@codelipenghui codelipenghui merged commit 1d4ca6b into apache:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants