Add a default timeout for OAuth2 Metadata Resolver #14056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there is no timeout on the metadata resolver in oauth2 clients. This can result in a connection hanging indefintely. We should add sane defaults here. These defaults match the defaults of the TokenClient and generally the Pulsar defaults of 10s connect timeout and 30s read timeout
|
@addisonj:Thanks for your contribution. For this PR, do we need to update docs? |
codelipenghui
added
the
type/enhancement
codelipenghui
approved these changes
Jan 30, 2022
MarvinCai
approved these changes
Jan 30, 2022
tuteng
approved these changes
Jan 30, 2022
merlimat
pushed a commit
that referenced
this pull request
Feb 1, 2022
## Motivation Currently, there is no timeout on the metadata resolver in oauth2 clients. This can result in a connection hanging indefintely. We should add sane defaults here. ## Modification These defaults match the defaults of the TokenClient and generally the Pulsar defaults of 10s connect timeout and 30s read timeout ## Test This seems to primarily depend on testing timeout of the java HTTP lib, so no test is likely needed. ## Doc This is a trivial change and doesn't require docs
merlimat
pushed a commit
that referenced
this pull request
Feb 1, 2022
## Motivation Currently, there is no timeout on the metadata resolver in oauth2 clients. This can result in a connection hanging indefintely. We should add sane defaults here. ## Modification These defaults match the defaults of the TokenClient and generally the Pulsar defaults of 10s connect timeout and 30s read timeout ## Test This seems to primarily depend on testing timeout of the java HTTP lib, so no test is likely needed. ## Doc This is a trivial change and doesn't require docs
merlimat
added
cherry-picked/branch-2.8
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
## Motivation Currently, there is no timeout on the metadata resolver in oauth2 clients. This can result in a connection hanging indefintely. We should add sane defaults here. ## Modification These defaults match the defaults of the TokenClient and generally the Pulsar defaults of 10s connect timeout and 30s read timeout ## Test This seems to primarily depend on testing timeout of the java HTTP lib, so no test is likely needed. ## Doc This is a trivial change and doesn't require docs
Anonymitaet
added
doc-not-needed
|
When submitting a PR, can you provide doc-related info (tick the box) in the PR description? So that Bot can recognize and label your PR correspondingly. Or else Bot labels your PR with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no timeout on the metadata resolver in oauth2
clients.
This can result in a connection hanging indefintely.
We should add sane defaults here.
These defaults match the defaults of the TokenClient and generally the
Pulsar defaults of 10s connect timeout and 30s read timeout
Test
This seems to primarily depend on testing timeout of the java HTTP lib, so no test is likely needed.
Doc
This is a trivial change and doesn't require docs