Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Broker]make revokePermissionsOnTopic method async #14149

Merged
merged 13 commits into from
Apr 20, 2022
Merged

[Broker]make revokePermissionsOnTopic method async #14149

merged 13 commits into from
Apr 20, 2022

Conversation

liudezhi2098
Copy link
Contributor

Master Issue: #14013

Motivation

Avoid call sync method in async rest API for PersistentTopicsBase#internalRevokePermissionsOnTopic.

Modifications

  • Use async instead of sync method.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Need to update docs?

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 7, 2022
@Technoboy- Technoboy- mentioned this pull request Feb 8, 2022
Closed
19 tasks
mattisonchao
mattisonchao reviewed Feb 9, 2022
View reviewed changes
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java Outdated Show resolved Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java Outdated Show resolved Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java Outdated Show resolved Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java Outdated Show resolved Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java Outdated Show resolved Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/PersistentTopics.java Show resolved Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java Show resolved Hide resolved
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@liudezhi2098
Copy link
Contributor Author

@codelipenghui @Technoboy- @mattisonchao PTAL .

@liudezhi2098
Copy link
Contributor Author

/pulsarbot run-failure-checks

@sijie sijie mentioned this pull request Mar 21, 2022
Open
19 tasks
@liudezhi2098 liudezhi2098 requested a review from Technoboy- April 12, 2022 13:02
@codelipenghui codelipenghui added this to the 2.11.0 milestone Apr 13, 2022
Technoboy-
Technoboy- approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liudezhi2098
Copy link
Contributor Author

/pulsarbot run-failure-checks

@liudezhi2098
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit d7ddda8 into apache:master Apr 20, 2022
@codelipenghui
Copy link
Contributor

Depends by #15694

codelipenghui pushed a commit that referenced this pull request Jun 12, 2022
@liudezhi2098 @codelipenghui
[Broker]make revokePermissionsOnTopic method async (#14149)
a7f3efa 
(cherry picked from commit d7ddda8)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jun 13, 2022
@liudezhi2098 @nicoloboschi
[Broker]make revokePermissionsOnTopic method async (apache#14149)
64f5de7 
(cherry picked from commit d7ddda8)
(cherry picked from commit a7f3efa)
BewareMyPower pushed a commit that referenced this pull request Jul 28, 2022
@codelipenghui @BewareMyPower
[branch-2.8][fix][security] Add timeout of sync methods and avoid cal…
3a04eb5 
…l sync method for AuthoriationService (#15694)

(cherry picked from commit 6af365e)

Besides resolving the basic conflicts, this PR
- migrate `validateAdminAccessForTenantAsync` from #14149
- migrate `TenantResources#getTenantAsync` from #11693
@BewareMyPower BewareMyPower mentioned this pull request Jul 28, 2022
Merged
4 tasks
BewareMyPower pushed a commit that referenced this pull request Jul 28, 2022
@codelipenghui @BewareMyPower
[branch-2.8][fix][security] Add timeout of sync methods and avoid cal…
a4ece07 
…l sync method for AuthoriationService (#15694)

(cherry picked from commit 6af365e)

Besides resolving the basic conflicts, this PR
- migrate `validateAdminAccessForTenantAsync` from #14149
- migrate `TenantResources#getTenantAsync` from #11693
BewareMyPower pushed a commit that referenced this pull request Jul 28, 2022
@codelipenghui @BewareMyPower
[branch-2.8][fix][security] Add timeout of sync methods and avoid cal…
5bb38a8 
…l sync method for AuthoriationService (#15694)

(cherry picked from commit 6af365e)

Besides resolving the basic conflicts, this PR
- migrate `validateAdminAccessForTenantAsync` from #14149
- migrate `TenantResources#getTenantAsync` from #11693
BewareMyPower pushed a commit that referenced this pull request Jul 29, 2022
@codelipenghui @BewareMyPower
[branch-2.8][fix][security] Add timeout of sync methods and avoid cal…
553b6d7 
…l sync method for AuthoriationService (#15694)

(cherry picked from commit 6af365e)

Besides resolving the basic conflicts, this PR
- migrate `validateAdminAccessForTenantAsync` from #14149
- migrate `TenantResources#getTenantAsync` from #11693
BewareMyPower added a commit that referenced this pull request Aug 2, 2022
@BewareMyPower @codelipenghui
[branch-2.8][fix][security] Add timeout of sync methods and avoid cal…
d81568e 
…l sync method for AuthoriationService (#15694) (#16831)

(cherry picked from commit 6af365e)

Besides resolving the basic conflicts, this PR
- migrate `validateAdminAccessForTenantAsync` from #14149
- migrate `TenantResources#getTenantAsync` from #11693

Co-authored-by: lipenghui <penghui@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattisonchao mattisonchao mattisonchao left review comments

@nodece nodece nodece approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

Assignees

@liudezhi2098 liudezhi2098

Labels
cherry-picked/branch-2.10 doc-not-needed Your PR changes do not impact docs release/2.10.1
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@liudezhi2098 @codelipenghui @Technoboy- @nodece @mattisonchao