Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about subscribeRate #14342

Merged
merged 3 commits into from
Feb 28, 2022
Merged

[Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about subscribeRate #14342

merged 3 commits into from
Feb 28, 2022

Conversation

AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Feb 17, 2022

Master Issue: #13756

Motivation

See issue: #13756

Modifications

  • Add field subscribeRate in org.apache.pulsar.common.policies.data.HierarchyTopicPolicies
  • Methods to update subscribeRate in org.apache.pulsar.broker.service.AbstractTopic
  • Other Modifications are concerning on org.apache.pulsar.broker.service.persistent.SubscribeRateLimiter where subscribeRate are used

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 17, 2022
@AnonHxy AnonHxy changed the title [Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about subscribeRate [WIP][Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about subscribeRate Feb 17, 2022
@Jason918 Jason918 mentioned this pull request Feb 17, 2022
Closed
23 tasks
@AnonHxy AnonHxy changed the title [WIP][Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about subscribeRate [Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about subscribeRate Feb 18, 2022
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Feb 18, 2022

/pulsarbot run-failure-checks

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Feb 18, 2022

@Jason918 PTAL

Jason918
Jason918 previously approved these changes Feb 19, 2022
View reviewed changes
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor suggestions.

@codelipenghui codelipenghui merged commit 989fc35 into apache:master Feb 28, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@AnonHxy
[Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicie…
221bab8 
…s about subscribeRate (apache#14342)
AnonHxy added a commit to AnonHxy/pulsar that referenced this pull request Jul 25, 2022
@AnonHxy
[Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicie…
71b4ced 
…s about subscribeRate (apache#14342)
@AnonHxy AnonHxy mentioned this pull request Jul 25, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jason918 Jason918 Jason918 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@315157973 315157973 Awaiting requested review from 315157973

Assignees

@AnonHxy AnonHxy

Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnonHxy @Jason918 @codelipenghui