Fix adding message to list potential issue #14377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattisonchao
approved these changes
Feb 18, 2022
BewareMyPower
added
release/2.8.4
release/2.9.3
type/bug
BewareMyPower
approved these changes
Feb 18, 2022
Demogorgon314
approved these changes
Feb 18, 2022
merlimat
approved these changes
Feb 18, 2022
michaeljmarshall
pushed a commit
that referenced
this pull request
Feb 24, 2022
(cherry picked from commit b22445f)
codelipenghui
pushed a commit
that referenced
this pull request
Feb 25, 2022
(cherry picked from commit b22445f)
nicoloboschi
pushed a commit
to nicoloboschi/pulsar
that referenced
this pull request
Mar 1, 2022
gaoran10
pushed a commit
that referenced
this pull request
Mar 1, 2022
(cherry picked from commit b22445f)
Shawyeok
reviewed
Mar 15, 2022
| @@ -1907,18 +1907,17 @@ protected void completeOpBatchReceive(OpBatchReceive<T> op) { | |||
| return CompletableFuture.completedFuture(Collections.emptyList()); | |||
| } | |||
| List<MessageIdData> data = new ArrayList<>(messageIds.size()); | |||
There was a problem hiding this comment.
There are seem another potential race condition, use ArrayList in possible multithread scenario is unsafe.
There was a problem hiding this comment.
I've create #14687 to continue this discussion.
2 tasks
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There may exist potential issue when adding MessageIdData into
data, because when the future is triggered, thedataobject was not guarantee to be already filled in.Documentation
no-need-doc