[Issue 13019][es-sink] Support event-time-based index name in ES Sink #14383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fantapsody:Thanks for your contribution. For this PR, do we need to update docs? |
|
@fantapsody:Thanks for providing doc info! |
github-actions
bot
added
doc
Anonymitaet
reviewed
Feb 21, 2022
...-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfig.java
Outdated
Show resolved
Hide resolved
...r-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/IndexNameFormatter.java
Outdated
Show resolved
Hide resolved
|
Discussed w/ @fantapsody
|
Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
|
@eolivelli @freeznet @nlu90 @tuteng Could you please take a look? |
freeznet
approved these changes
Feb 28, 2022
tuteng
approved these changes
Feb 28, 2022
tuteng
added
the
type/enhancement
Anonymitaet
reviewed
Feb 28, 2022
| @@ -50,7 +50,7 @@ The configuration of the Elasticsearch sink connector has the following properti | |||
| | Name | Type|Required | Default | Description | |||
| |------|----------|----------|---------|-------------| | |||
| | `elasticSearchUrl` | String| true |" " (empty string)| The URL of elastic search cluster to which the connector connects. | | |||
| | `indexName` | String| true |" " (empty string)| The index name to which the connector writes messages. | | |||
| | `indexName` | String| true |" " (empty string)| The index name to which the connector writes messages. The default value is the topic name. It accepts date formats in the name to support event time based index with the pattern `%{+<date-format>}`. For example, suppose the event time of the record is 1645182000000L, the indexName is `logs-%{+yyyy-MM-dd}`, then the formatted index name would be `logs-2022-02-18`. | | |||
There was a problem hiding this comment.
Hi @fantapsody the docs should be added to site2/docs/io-elasticsearch-sink.md as well.
3 tasks
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…apache#14383) Fixes apache#13019 ### Motivation As described in the original issue, it's a common request to write data to event-time-based indices in logs and metrics use cases, therefore it would be very helpful to have builtin support in the ES sink. ### Modifications *Describe the modifications you've done.* ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change added tests and can be verified as follows: - *Added test cases for index name formatter*
|
@tuteng @fantapsody @codelipenghui this pull is not present in Pulsar 2.10. I believe it has not been cherry-picked to branch-2.10 at all |
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 28, 2022
…apache#14383) Fixes apache#13019 ### Motivation As described in the original issue, it's a common request to write data to event-time-based indices in logs and metrics use cases, therefore it would be very helpful to have builtin support in the ES sink. ### Modifications *Describe the modifications you've done.* ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change added tests and can be verified as follows: - *Added test cases for index name formatter* (cherry picked from commit 21c3a0b)
codelipenghui
pushed a commit
that referenced
this pull request
Apr 29, 2022
…#14383) Fixes #13019 ### Motivation As described in the original issue, it's a common request to write data to event-time-based indices in logs and metrics use cases, therefore it would be very helpful to have builtin support in the ES sink. ### Modifications *Describe the modifications you've done.* ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change added tests and can be verified as follows: - *Added test cases for index name formatter* (cherry picked from commit 21c3a0b)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13019
Motivation
As described in the original issue, it's a common request to write data to event-time-based indices in logs and metrics use cases, therefore it would be very helpful to have builtin support in the ES sink.
Modifications
Describe the modifications you've done.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)