Initialize: Minimum receiverQueueSize should be number of partitions in a partition consumer #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in a partition consumer
|
CLA is valid! |
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
…ar proxy (apache#146) if producer connect to broker through pulsar proxy, producer will get Short read when reading frame size error because pulsar proxy not pass commands to broker.
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
Co-authored-by: weikang.yuan <yuanwk@inke.cn>
nicoloboschi
pushed a commit
to nicoloboschi/pulsar
that referenced
this pull request
Oct 12, 2022
… from OODM (apache#146) Modifications: - limit the global number of pending reads to BookKeeper - new configuration entry managedLedgerMaxPendingReadsBufferSizeInMB (0 = feature disabled) - we estimate the entry size per-topic, using the size of the last read entry (new metric pulsar_ml_pending_reads_estimated_entry_size, per topic) - new metric pulsar_ml_pending_reads_buffer_sizeto get the estimated size of in-flight read requests in bytes - if the feature is disabled this changed does not add significant overhead Result: This prevents the broker from going to OutOfMemory (direct memory) in case of many concurrent reads from the bookie
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PartitionedConsumer with receiverQueueSize=1 initializes receiverQueue with type of
ArrayBlockingQueuewhich can't consume messages from multiple partitions. Therefore, minimum size of partitioned-consumer's receiverQueue should be: Number of partitions in the topic.Result
It can support partitioned-consumer with queue-size 1.