Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] [Do-not-merge] add doc for Oauth2 authentication support in node.js client and update doc for custom AuthN/AuthZ #14659

Merged
merged 3 commits into from
Mar 18, 2022
Merged

[Doc] [Do-not-merge] add doc for Oauth2 authentication support in node.js client and update doc for custom AuthN/AuthZ #14659

merged 3 commits into from
Mar 18, 2022

Conversation

momo-jun
Copy link
Contributor

@momo-jun momo-jun commented Mar 11, 2022 •
edited
Loading

Modifications

  1. To align with the latest release of node.js client 1.6.2 and fix [Doc] Add doc of OAuth2 authentication for Node.js client #14143, add doc for Oauth2 authentication support in node.js client.
  2. To align with [broker][authentication]Support pass http auth status #14044 for 2.11, update doc for extended AuthN/AuthZ by replacing outdated info and code samples with github URLs, adding more auth providers with links to examples.
  3. Fix minor writing issues in the content involved.

The preview looks good.
image
image

Documentation

  • doc

@github-actions
Copy link

@momo-jun:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions
Copy link

@momo-jun:Thanks for providing doc info!

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Mar 11, 2022
@momo-jun
Copy link
Contributor Author

Hi @tuteng @Anonymitaet can you please review this doc PR? Thank you.

Anonymitaet
Anonymitaet reviewed Mar 14, 2022
View reviewed changes
site2/docs/security-extending.md Outdated Show resolved Hide resolved
site2/docs/security-extending.md Outdated Show resolved Hide resolved
site2/docs/security-oauth2.md Outdated Show resolved Hide resolved
@momo-jun momo-jun changed the title [Doc] add doc for Oauth2 authentication support in node.js client and update doc for custom AuthN/AuthZ [Doc] [Do-not-merge, for 2.11 only] add doc for Oauth2 authentication support in node.js client and update doc for custom AuthN/AuthZ Mar 14, 2022
tuteng
tuteng reviewed Mar 17, 2022
View reviewed changes
Copy link
Member

@tuteng tuteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Also I don't think the nodejs client supporting oauth2 authentication needs to wait for pulsar 2.11 to be released, the puslar node client was released separately

@momo-jun momo-jun changed the title [Doc] [Do-not-merge, for 2.11 only] add doc for Oauth2 authentication support in node.js client and update doc for custom AuthN/AuthZ [Doc] [Do-not-merge] add doc for Oauth2 authentication support in node.js client and update doc for custom AuthN/AuthZ Mar 17, 2022
@momo-jun
Copy link
Contributor Author

Thanks @Anonymitaet and @tuteng for your comments. I've fixed them. PTAL.

@Anonymitaet Anonymitaet added this to the 2.10.0 milestone Mar 17, 2022
@Anonymitaet Anonymitaet merged commit ff5d8eb into apache:master Mar 18, 2022
aparajita89 pushed a commit to aparajita89/pulsar that referenced this pull request Mar 21, 2022
@momo-jun
[Doc] add doc for Oauth2 authentication support in node.js client and…
7921772 
… update doc for custom AuthN/AuthZ (apache#14659)
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@momo-jun
[Doc] add doc for Oauth2 authentication support in node.js client and…
be95f5a 
… update doc for custom AuthN/AuthZ (apache#14659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anonymitaet Anonymitaet Anonymitaet approved these changes

@tuteng tuteng tuteng approved these changes

Assignees

@momo-jun momo-jun

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

[Doc] Add doc of OAuth2 authentication for Node.js client
3 participants
@momo-jun @tuteng @Anonymitaet