Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating failure-domain for cluster which doesn't exist #1474

Merged
merged 2 commits into from
Mar 30, 2018
Merged

Avoid creating failure-domain for cluster which doesn't exist #1474

merged 2 commits into from
Mar 30, 2018

Conversation

rdhabalia
Copy link
Contributor

@rdhabalia rdhabalia commented Mar 30, 2018 •
edited
Loading

Motivation

Right now, if cluster is not created yet then broker creates empty cluster-znode in order to create failure-domain under cluster. It creates conflict when we really want to create cluster in pulsar.

Modifications

Avoid creating failure-domain znode if cluster is not created yet. It reverts some of the test-case changes made in #896

Result

It will not create any conflict while creating cluster in the system.

@rdhabalia rdhabalia added the type/bug The PR fixed a bug or issue reported a bug label Mar 30, 2018
@rdhabalia rdhabalia added this to the 2.0.0-incubating milestone Mar 30, 2018
@rdhabalia rdhabalia self-assigned this Mar 30, 2018
merlimat
merlimat approved these changes Mar 30, 2018
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat
Copy link
Contributor

@rdhabalia Still few tests failing :

org.apache.pulsar.broker.web.RestException: Cluster does not exist
	at org.apache.pulsar.broker.admin.impl.ClustersBase.updateCluster(ClustersBase.java:156)
	at org.apache.pulsar.broker.admin.AdminTest.brokers(AdminTest.java:495)

@merlimat merlimat merged commit 7fa7202 into apache:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

Assignees

@rdhabalia rdhabalia

Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.0.0-incubating
Development

Successfully merging this pull request may close these issues.
2 participants
@rdhabalia @merlimat