[fix][txn]: fix some exception handle in transaction buffer #14808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
added
area/transaction
doc-not-needed
codelipenghui
approved these changes
Mar 23, 2022
|
/pulsarbot run-failure-checks |
gaoran10
approved these changes
Mar 23, 2022
| @@ -342,7 +342,7 @@ public void addFailed(ManagedLedgerException exception, Object ctx) { | |||
| } | |||
| }).exceptionally(exception -> { | |||
| log.error("Transaction {} abort on topic {}.", txnID.toString(), topic.getName()); | |||
There was a problem hiding this comment.
Suggested change
| log.error("Transaction {} abort on topic {}.", txnID.toString(), topic.getName()); | |
| log.error("Transaction {} abort on topic {}.", txnID.toString(), topic.getName(), exception.getCause()); |
| @@ -296,7 +296,7 @@ public void addFailed(ManagedLedgerException exception, Object ctx) { | |||
| } | |||
| }).exceptionally(exception -> { | |||
| log.error("Transaction {} commit on topic {}.", txnID.toString(), topic.getName(), exception); | |||
There was a problem hiding this comment.
Suggested change
| log.error("Transaction {} commit on topic {}.", txnID.toString(), topic.getName(), exception); | |
| log.error("Transaction {} commit on topic {}.", txnID.toString(), topic.getName(), exception.getCause()); |
| @@ -218,7 +218,7 @@ public void recoverExceptionally(Exception e) { | |||
| } | |||
| }).exceptionally(exception -> { | |||
| log.error("Topic {}: TransactionBuffer recover failed", this.topic.getName(), exception); | |||
There was a problem hiding this comment.
Suggested change
| log.error("Topic {}: TransactionBuffer recover failed", this.topic.getName(), exception); | |
| log.error("Topic {}: TransactionBuffer recover failed", this.topic.getName(), exception.getCause()); |
codelipenghui
approved these changes
Mar 24, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Mar 25, 2022
(cherry picked from commit 4824912)
codelipenghui
pushed a commit
that referenced
this pull request
Apr 19, 2022
(cherry picked from commit 4824912)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fix some exception return in transaction buffer
Modifications
use exception.getCause();
Verifying this change
add test for it
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation