-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][client] Avoid timer task run before previous subscribe complete. #14818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/pulsarbot rerun-failure-checks |
Technoboy-
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Demogorgon314
approved these changes
Mar 24, 2022
codelipenghui
approved these changes
Mar 24, 2022
codelipenghui
added
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
component/client-java
labels
Mar 24, 2022
@mattisonchao I'm not able to cherry-pick this one to branch-2.9, could you please help push a fix to branch-2.9 directly? |
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…ete. (apache#14818) ### Motivation If configuration ``patternAutoDiscoveryPeriod`` is small, there may be some unnecessary subscribe requests. ### Modifications *Describe the modifications you've done.*
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 23, 2022
…ete. (apache#14818) If configuration ``patternAutoDiscoveryPeriod`` is small, there may be some unnecessary subscribe requests. *Describe the modifications you've done.* (cherry picked from commit 0fe921f) (cherry picked from commit fa227a0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-2.8
Archived: 2.8 is end of life
cherry-picked/branch-2.9
Archived: 2.9 is end of life
cherry-picked/branch-2.10
doc-not-needed
Your PR changes do not impact docs
release/2.8.4
release/2.9.3
release/2.10.1
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If configuration
patternAutoDiscoveryPeriod
is small, there may be some unnecessary subscribe requests.Modifications
Describe the modifications you've done.
Verifying this change
Documentation
no-need-doc