Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][client] Avoid timer task run before previous subscribe complete. #14818

Merged
merged 1 commit into from
Mar 24, 2022
Merged

[improve][client] Avoid timer task run before previous subscribe complete. #14818

merged 1 commit into from
Mar 24, 2022

Conversation

mattisonchao
Copy link
Member

Motivation

If configuration patternAutoDiscoveryPeriod is small, there may be some unnecessary subscribe requests.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 23, 2022
@mattisonchao
Copy link
Member Author

/pulsarbot rerun-failure-checks

Copy link
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codelipenghui codelipenghui added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages component/client-java labels Mar 24, 2022
@codelipenghui codelipenghui merged commit 0fe921f into apache:master Mar 24, 2022
@codelipenghui
Copy link
Contributor

@mattisonchao I'm not able to cherry-pick this one to branch-2.9, could you please help push a fix to branch-2.9 directly?

codelipenghui pushed a commit that referenced this pull request Apr 19, 2022
…ete. (#14818)

### Motivation

If configuration  ``patternAutoDiscoveryPeriod`` is small, there may be some unnecessary subscribe requests.

### Modifications

*Describe the modifications you've done.*

(cherry picked from commit 0fe921f)
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
…ete. (apache#14818)

### Motivation

If configuration  ``patternAutoDiscoveryPeriod`` is small, there may be some unnecessary subscribe requests.

### Modifications

*Describe the modifications you've done.*
codelipenghui pushed a commit that referenced this pull request May 20, 2022
…ete. (#14818)

If configuration  ``patternAutoDiscoveryPeriod`` is small, there may be some unnecessary subscribe requests.

*Describe the modifications you've done.*

(cherry picked from commit 0fe921f)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label May 20, 2022
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request May 23, 2022
…ete. (apache#14818)

If configuration  ``patternAutoDiscoveryPeriod`` is small, there may be some unnecessary subscribe requests.

*Describe the modifications you've done.*

(cherry picked from commit 0fe921f)
(cherry picked from commit fa227a0)
@mattisonchao mattisonchao added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 doc-not-needed Your PR changes do not impact docs release/2.8.4 release/2.9.3 release/2.10.1 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants