[fix][transaction] Close the transaction buffer when deleting topics #14895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the transaction buffer don't be closed when deleting topic. # Modification Close the transaction buffer when deleting topic.
gaoran10
requested review from
eolivelli,
codelipenghui,
congbobo184,
merlimat,
Technoboy- and
zymap
gaoran10
added
area/transaction
type/bug
Technoboy-
approved these changes
Mar 27, 2022
eolivelli
approved these changes
Mar 27, 2022
merlimat
approved these changes
Mar 29, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Mar 30, 2022
Currently, the transaction buffer don't be closed when deleting topic. # Modification Close the transaction buffer when deleting topic. (cherry picked from commit e8d52fd)
codelipenghui
pushed a commit
that referenced
this pull request
Apr 19, 2022
Currently, the transaction buffer don't be closed when deleting topic. # Modification Close the transaction buffer when deleting topic. (cherry picked from commit e8d52fd)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
Currently, the transaction buffer don't be closed when deleting topic. # Modification Close the transaction buffer when deleting topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14879
Motivation
Currently, the transaction buffer doesn't be closed when deleting topics, this will cause readers of the transaction buffer snapshot topic are leak.
Modifications
Close the transaction buffer when deleting topics.
Verifying this change
Add transaction buffer close test.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)