Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TieredStorage: add debug information #14907

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

eolivelli
Copy link
Contributor

Motivation

Currently it is very hard to debug Tiered Storage Offloading:

  • no logs
  • no way to match the objects with the Managed Ledger (and with the Pulsar cluster)

Modifications

  • enable SLF4 logging in JClouds
  • add Pulsar Cluster name in Objects metadata
  • log object names during offloading

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

- enable SLF4 logging in JClouds
- add Pulsar Cluster name in Objects metadata
- log object names during offloading
@github-actions
Copy link

@eolivelli:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@eolivelli eolivelli added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Mar 28, 2022
Copy link
Member

@michaeljmarshall michaeljmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli eolivelli merged commit 83dad0a into apache:master Mar 29, 2022
@eolivelli eolivelli deleted the impl/offload-more-debug branch March 29, 2022 07:48
@codelipenghui codelipenghui added this to the 2.11.0 milestone Mar 29, 2022
eolivelli added a commit that referenced this pull request Mar 29, 2022
* TieredStorage: add debug information
- enable SLF4 logging in JClouds
- add Pulsar Cluster name in Objects metadata
- log object names during offloading

(cherry picked from commit 83dad0a)
eolivelli added a commit that referenced this pull request Mar 29, 2022
* TieredStorage: add debug information
- enable SLF4 logging in JClouds
- add Pulsar Cluster name in Objects metadata
- log object names during offloading

(cherry picked from commit 83dad0a)
@eolivelli eolivelli added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Mar 29, 2022
eolivelli added a commit that referenced this pull request Mar 29, 2022
* TieredStorage: add debug information
- enable SLF4 logging in JClouds
- add Pulsar Cluster name in Objects metadata
- log object names during offloading

(cherry picked from commit 83dad0a)
@eolivelli eolivelli added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Mar 29, 2022
eolivelli added a commit to datastax/pulsar that referenced this pull request Mar 29, 2022
* TieredStorage: add debug information
- enable SLF4 logging in JClouds
- add Pulsar Cluster name in Objects metadata
- log object names during offloading

(cherry picked from commit 83dad0a)
eolivelli added a commit to datastax/pulsar that referenced this pull request Mar 29, 2022
* TieredStorage: add debug information
- enable SLF4 logging in JClouds
- add Pulsar Cluster name in Objects metadata
- log object names during offloading

(cherry picked from commit 83dad0a)
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
* TieredStorage: add debug information
- enable SLF4 logging in JClouds
- add Pulsar Cluster name in Objects metadata
- log object names during offloading
lhotari pushed a commit to datastax/pulsar that referenced this pull request May 9, 2022
* TieredStorage: add debug information
- enable SLF4 logging in JClouds
- add Pulsar Cluster name in Objects metadata
- log object names during offloading

(cherry picked from commit 83dad0a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants