[fix][Transaction] Fix transaction admin redirect get 500 due to getCause #14965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ause ### Motivation Transaction admin `getCoordinatorInternalStats` and `getPendingAckInternalStats` add a getCause when try catch. Which make redirect fail.
congbobo184
requested review from
eolivelli,
congbobo184,
gaoran10 and
codelipenghui
congbobo184
added
area/transaction
doc-not-needed
Technoboy-
reviewed
Mar 31, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TransactionsBase.java
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
gaoran10
reviewed
Apr 1, 2022
...oker/src/test/java/org/apache/pulsar/broker/admin/v3/AdminApiTransactionMultiBrokerTest.java
Show resolved
Hide resolved
…irect_for_getcause
|
/pulsarbot run-failure-checks |
3 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
gaoran10
reviewed
Apr 6, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TransactionsBase.java
Outdated
Show resolved
Hide resolved
gaoran10
approved these changes
Apr 6, 2022
|
/pulsarbot run-failure-checks |
Technoboy-
approved these changes
Apr 7, 2022
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
…irect_for_getcause
congbobo184
approved these changes
Apr 8, 2022
aparajita89
pushed a commit
to aparajita89/pulsar
that referenced
this pull request
Apr 18, 2022
…ause (apache#14965) ### Motivation Transaction admin `getCoordinatorInternalStats` add a getCause when try catch. Which make redirect fail. * Exception is thrown by `validateTopicOwnership`, sync() call get() in `sync(()-> validateTopicOwnershipAsync(topicName, authoritative));` * Exception already got cause by in `validateTopicOwnershipAsync` ### Modifications Delete get cause if not ExecutionException
codelipenghui
pushed a commit
that referenced
this pull request
Apr 19, 2022
…ause (#14965) ### Motivation Transaction admin `getCoordinatorInternalStats` add a getCause when try catch. Which make redirect fail. * Exception is thrown by `validateTopicOwnership`, sync() call get() in `sync(()-> validateTopicOwnershipAsync(topicName, authoritative));` * Exception already got cause by in `validateTopicOwnershipAsync` ### Modifications Delete get cause if not ExecutionException (cherry picked from commit 74df947)
codelipenghui
pushed a commit
that referenced
this pull request
Apr 19, 2022
…ause (#14965) ### Motivation Transaction admin `getCoordinatorInternalStats` add a getCause when try catch. Which make redirect fail. * Exception is thrown by `validateTopicOwnership`, sync() call get() in `sync(()-> validateTopicOwnershipAsync(topicName, authoritative));` * Exception already got cause by in `validateTopicOwnershipAsync` ### Modifications Delete get cause if not ExecutionException (cherry picked from commit 74df947)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…ause (apache#14965) ### Motivation Transaction admin `getCoordinatorInternalStats` add a getCause when try catch. Which make redirect fail. * Exception is thrown by `validateTopicOwnership`, sync() call get() in `sync(()-> validateTopicOwnershipAsync(topicName, authoritative));` * Exception already got cause by in `validateTopicOwnershipAsync` ### Modifications Delete get cause if not ExecutionException
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Transaction admin
getCoordinatorInternalStatsadd a getCause when try catch.Which make redirect fail.
validateTopicOwnership, sync() call get() insync(()-> validateTopicOwnershipAsync(topicName, authoritative));validateTopicOwnershipAsyncModifications
Delete get cause if not ExecutionException
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)