[Fix][Transaction] Fix transaction pendingAckStore asyncMarkDelete #14974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation When we only use transaction to ack message, a message per transaction, `cursor.asyncMarkDelete` will never be executed, because firstPosition and deletePosition both are init as metadataPositions.firstEntry().getKey(); And if only the firstkey need to delete, deletePosition also get metadataPositions.firstKey(); irstPosition == deletePosition, never call `cursor.asyncMarkDelete` ### Modification init firstPosition and deletePosition as PositionImpl.EARLIEST
congbobo184
added
release/2.9.3
release/2.10.1
area/transaction
type/bug
congbobo184
requested review from
eolivelli,
congbobo184,
codelipenghui and
gaoran10
congbobo184
approved these changes
Apr 1, 2022
|
/pulsarbot run-failure-checks |
gaoran10
reviewed
Apr 1, 2022
...er/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java
Outdated
Show resolved
Hide resolved
gaoran10
approved these changes
Apr 1, 2022
codelipenghui
approved these changes
Apr 1, 2022
…dingack_markedelete
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java
Outdated
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
…dingack_markedelete
congbobo184
pushed a commit
that referenced
this pull request
Apr 2, 2022
…14974) ### Motivation When we only use transaction to ack message, a message per transaction, `cursor.asyncMarkDelete` will never be executed, because firstPosition and deletePosition both are init as metadataPositions.firstEntry().getKey(); And if only the firstkey need to delete, deletePosition also get metadataPositions.firstKey(); irstPosition == deletePosition, never call `cursor.asyncMarkDelete` ### Modification init firstPosition and deletePosition as PositionImpl.EARLIEST (cherry picked from commit 8a6ecd7)
codelipenghui
pushed a commit
that referenced
this pull request
Apr 19, 2022
…14974) ### Motivation When we only use transaction to ack message, a message per transaction, `cursor.asyncMarkDelete` will never be executed, because firstPosition and deletePosition both are init as metadataPositions.firstEntry().getKey(); And if only the firstkey need to delete, deletePosition also get metadataPositions.firstKey(); irstPosition == deletePosition, never call `cursor.asyncMarkDelete` ### Modification init firstPosition and deletePosition as PositionImpl.EARLIEST (cherry picked from commit 8a6ecd7)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…pache#14974) ### Motivation When we only use transaction to ack message, a message per transaction, `cursor.asyncMarkDelete` will never be executed, because firstPosition and deletePosition both are init as metadataPositions.firstEntry().getKey(); And if only the firstkey need to delete, deletePosition also get metadataPositions.firstKey(); irstPosition == deletePosition, never call `cursor.asyncMarkDelete` ### Modification init firstPosition and deletePosition as PositionImpl.EARLIEST
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we only use transaction to ack message, a message per transaction,
cursor.asyncMarkDeletewill never be executed, because firstPosition anddeletePosition both are init as metadataPositions.firstEntry().getKey();
And if only the firstkey need to delete, deletePosition also get metadataPositions.firstKey(); irstPosition == deletePosition, never call
cursor.asyncMarkDeleteModification
init firstPosition and deletePosition as PositionImpl.EARLIEST
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)