[fix][client] ConsumerBuilderImpl can not set null to deadLetterPolicy. #14980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hezhangjian
approved these changes
Apr 1, 2022
RobertIndie
approved these changes
Apr 1, 2022
RobertIndie
added
type/bug
Technoboy-
approved these changes
Apr 1, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 5, 2022
apache#14980) `ConsumerBuilderImpl` can not set null to deadLetterPolicy if it's already assigned a non-null value. Calls `conf.setDeadLetterPolicy` if `deadLetterPolicy` is null. (cherry picked from commit 2f53071) (cherry picked from commit a4c6ae4)
codelipenghui
added
cherry-picked/branch-2.9
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
apache#14980) ### Motivation `ConsumerBuilderImpl` can not set null to deadLetterPolicy if it's already assigned a non-null value. ### Modifications Calls `conf.setDeadLetterPolicy` if `deadLetterPolicy` is null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ConsumerBuilderImplcan not set null to deadLetterPolicy if it's already assigned a non-null value.Modifications
Calls
conf.setDeadLetterPolicyifdeadLetterPolicyis null.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docbug fix