Pulsar with Bk 4.15.0 #15142
Pulsar with Bk 4.15.0 #15142
Conversation
dlg99
force-pushed
the
bk-4.15
branch
14 times, most recently
from
7b39a98 to
3a5387f
Compare
|
You can add the repository for bk 4.15.0 rc0 This way we can run CI against the RC |
dlg99
changed the title
| * RxJava | ||
| - io.reactivex.rxjava3-rxjava-3.0.1.jar | ||
| * RabbitMQ Java Client | ||
| - com.rabbitmq-amqp-client-5.5.3.jar |
There was a problem hiding this comment.
Why do we need these 2 new libraries?
There was a problem hiding this comment.
mvn dependency:tree:
[INFO] +- org.apache.bookkeeper:bookkeeper-server:jar:4.15.0:compile
...
[INFO] | +- io.reactivex.rxjava3:rxjava:jar:3.0.1:compile
[INFO] | | \- org.reactivestreams:reactive-streams:jar:1.0.3:compile
[INFO] +- org.apache.bookkeeper.stats:codahale-metrics-provider:jar:4.15.0:compile
[INFO] | +- io.dropwizard.metrics:metrics-jmx:jar:4.1.12.1:compile
[INFO] | +- io.dropwizard.metrics:metrics-jvm:jar:4.1.12.1:compile
[INFO] | \- io.dropwizard.metrics:metrics-graphite:jar:4.1.12.1:compile
[INFO] | \- com.rabbitmq:amqp-client:jar:5.5.3:compile
RxJava as result of apache/bookkeeper#2936
amqp-client as part of dropwizard upgrade
There was a problem hiding this comment.
Since we're not going to use RabbitMQ client to export metrics, we could just exclude these dependencies.
There was a problem hiding this comment.
More over, I'm not sure why we're importing codahale-metrics-provider from managed-ledger. I think it's not needed at all :)
There was a problem hiding this comment.
Anyway, this should be handled separately and we should merge this now.
dlg99
changed the title
dlg99
changed the title
| } | ||
| return registrationManager; | ||
| } | ||
|
|
There was a problem hiding this comment.
Why do we make this change? It seems we generate an unreleased resource here.
cc @dlg99
Modifications
Upgraded BK to 4.15.0
Upgraded dependendencies, where applicable (license check to follow)
Fixed build breaks caused by BK, fixed tests etc (what's broken by new code or flakes I caught, was not sure if related)
Verifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
Needs release notes, probably
doc-required(Your PR needs to update docs and you will update later)
no-need-doc(Please explain why)
doc(Your PR contains doc changes)
doc-added(Docs have been already added)