-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[function] refine file io connector #15250
Merged
codelipenghui
merged 4 commits into
apache:master
from
streamnative:neng/refine-file-io-connector
Jun 12, 2022
Merged
[function] refine file io connector #15250
codelipenghui
merged 4 commits into
apache:master
from
streamnative:neng/refine-file-io-connector
Jun 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
May 4, 2022
merlimat
added
release/2.10.1
type/bug
The PR fixed a bug or issue reported a bug
release/2.9.3
labels
May 4, 2022
/pulsarbot run-failure-checks |
@freeznet Could you help take a look? |
freeznet
approved these changes
May 25, 2022
/pulsarbot run-failure-checks |
codelipenghui
force-pushed
the
neng/refine-file-io-connector
branch
from
June 9, 2022 04:33
638756e
to
e4d1d61
Compare
codelipenghui
pushed a commit
that referenced
this pull request
Jun 12, 2022
(cherry picked from commit cbefe3e)
mattisonchao
pushed a commit
that referenced
this pull request
Jun 13, 2022
(cherry picked from commit cbefe3e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-2.9
Archived: 2.9 is end of life
cherry-picked/branch-2.10
doc-not-needed
Your PR changes do not impact docs
release/2.9.3
release/2.10.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>
to link to the master issue.)Master Issue: #
Motivation
FileListingThread
doesn't need to do the permission check since theconfig.validate()
has already done it. Also, as a ListingThread, it doesn't need theWrite
permission on the directory.write
permission is needed only whenkeepFile
option is set tofalse
.Modifications
keepFile
is false.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required
(Your PR needs to update docs and you will update later)
no-need-doc
internal fix
doc
(Your PR contains doc changes)
doc-added
(Docs have been already added)