Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[function] refine file io connector #15250

Merged

Conversation

nlu90
Copy link
Member

@nlu90 nlu90 commented Apr 21, 2022

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

  1. FileListingThread doesn't need to do the permission check since the config.validate() has already done it. Also, as a ListingThread, it doesn't need the Write permission on the directory.
  2. write permission is needed only when keepFile option is set to false.

Modifications

  1. only do file writable permission check when keepFile is false.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • no-need-doc
    internal fix

  • doc
    (Your PR contains doc changes)

  • doc-added
    (Docs have been already added)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 21, 2022
@nlu90 nlu90 changed the title refine file io connector [function] refine file io connector Apr 27, 2022
@merlimat merlimat added this to the 2.11.0 milestone May 4, 2022
@merlimat merlimat added release/2.10.1 type/bug The PR fixed a bug or issue reported a bug release/2.9.3 labels May 4, 2022
@nlu90
Copy link
Member Author

nlu90 commented May 24, 2022

/pulsarbot run-failure-checks

@nlu90
Copy link
Member Author

nlu90 commented May 24, 2022

@freeznet Could you help take a look?

@nlu90
Copy link
Member Author

nlu90 commented Jun 3, 2022

/pulsarbot run-failure-checks

@codelipenghui codelipenghui force-pushed the neng/refine-file-io-connector branch from 638756e to e4d1d61 Compare June 9, 2022 04:33
@codelipenghui codelipenghui merged commit cbefe3e into apache:master Jun 12, 2022
@codelipenghui codelipenghui deleted the neng/refine-file-io-connector branch June 12, 2022 11:50
codelipenghui pushed a commit that referenced this pull request Jun 12, 2022
@mattisonchao mattisonchao added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Jun 13, 2022
mattisonchao pushed a commit that referenced this pull request Jun 13, 2022
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jun 13, 2022
(cherry picked from commit cbefe3e)
(cherry picked from commit 4a82c5b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 doc-not-needed Your PR changes do not impact docs release/2.9.3 release/2.10.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants